[prev in list] [next in list] [prev in thread] [next in thread] 

List:       spamassassin-users
Subject:    Re: header eval rules on 3.2.5 strip out a literal 0
From:       Mark Martinec <Mark.Martinec+sa () ijs ! si>
Date:       2009-08-25 13:59:10
Message-ID: 200908251559.10875.Mark.Martinec+sa () ijs ! si
[Download RAW message or body]

Michael,

> Mark Martinec wrote:
> > Fixed in 3.3.0:
> >   https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5965
>
> guess 3.3.0 is due out so soon that this won't be backported to 3.2.6?
>
> would that patch work on 3.2.5? (giving me an excuse for another port
> bump for SA?)

The posted patch will probably work for 3.2.5, but is more extensive
than necessary, and does not cover further cases discovered later.

Also (not directly related, but close), handling of 'exists' rule
has changed more fundamendally in 3.3, now it really tests for
existence of a header field, while previously (3.2.5) it tested for
nonempty header field body. That patch does not cover this change.

As all these changes were nontrivial and rather extensive,
and tested mainly in the 3.3 branch, I don't think it is
appropriate for backporting (without careful re-examination),
and even less for a minor ports patch. Perhaps a small subset
of the patch would do, if anyone wants to invest some time
in it.

  Mark
[prev in list] [next in list] [prev in thread] [next in thread]