[prev in list] [next in list] [prev in thread] [next in thread] 

List:       spamassassin-devel
Subject:    [Bug 8096] New: t/strip2.t fails if Text::Diff is not installed
From:       bugzilla-daemon () spamassassin ! apache ! org
Date:       2022-12-27 11:07:37
Message-ID: bug-8096-26 () https ! bz ! apache ! org/SpamAssassin/
[Download RAW message or body]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8096

            Bug ID: 8096
           Summary: t/strip2.t fails if Text::Diff is not installed
           Product: Spamassassin
           Version: 4.0.0
          Hardware: PC
                OS: Windows 10
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Regression Tests
          Assignee: dev@spamassassin.apache.org
          Reporter: spamassassinbugs_peep@parallaxshift.com
  Target Milestone: Undefined

Created attachment 5870
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5870&action=edit
Patch to strip2.t that disables it if Text::Diff is not available

strip2.t depends upon Text::Diff (and the test appears to be the only code that
uses that module).

It needs skip_all protection like the other tests which depend upon
non-documented external packages so it'll self disable.

==================================================================
use constant HAS_TEXTDIFF => eval { require Text::Diff; };

plan skip_all => 'Need Text::Diff' unless HAS_TEXTDIFF;
==================================================================

... and remove the "use Text::Diff" line.

-- 
You are receiving this mail because:
You are the assignee for the bug.=
[prev in list] [next in list] [prev in thread] [next in thread]