[prev in list] [next in list] [prev in thread] [next in thread]
List: spamassassin-devel
Subject: Re: /tags nightly commits
From: "Kevin A. McGrail" <kmcgrail () apache ! org>
Date: 2019-05-05 14:40:49
Message-ID: 3351142f-7c93-0ab7-c6a2-e9b48542450a () apache ! org
[Download RAW message or body]
Resending with correct dev list :-)
On 5/5/2019 6:10 AM, Paul Stead wrote:
> Promotions and tags still seem to be a little problematic at the moment. A
> run of build/mkupdates/listpromotable locally shows +300 lines difference
> to active.list over the one being submitted.
Before I deal with this issue:
+Dev.
TL;DR: REMINDER: PLEASE use a make test on your local checkout before
committing!
We had two issues. It appears an svn commit failed on a release and
that left cruft that was colliding for commit. That issue was caused by
a manual edit to active.list:
Revision *1854477*
<http://svn.apache.org/viewvc?view=revision&revision=1854477> - (view
<http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?revision=1854477&view=markup>)
(download
<http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?revision=1854477&view=co>)
(annotate
<http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?annotate=1854477>)
- [select for diffs]
<http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?view=log&r1=1854477>
Modified /Wed Feb 27 18:16:20 2019 UTC/ (2 months ago) by /gbechis/
File length: 15052 byte(s)
Diff to previous 1854447
<http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?r1=1854447&r2=1854477>
(colored
<http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?r1=1854447&r2=1854477&diff_format=h>)
Switch to https and fix some 404 errors
bz #7652
The second issue is a continuing one and that is committers submitting
without 'make test' first. This occurred in January when I tried to
build the last release. If the svn for trunk including rules is broken,
it will break masscheck, etc. We are currently passing again so just a
friendly reminder. It takes a village to stop a spammer :-)
So now, what I see in the logs is that the commit didn't occur but
there is no error, nothing. Checking
http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?view=log
concurs:
5/5 (note that Committing promotions is NOT followed by an svn commit)
+ echo 'Committing promotions in rules/active.list...'
+ svn commit -m 'promotions validated' rules/active.list
Committing promotions in rules/active.list...
+ /usr/bin/perl masses/rule-qa/list-bad-rules
5/4 (example where the commit worked)
+ echo 'Committing promotions in rules/active.list...'
Committing promotions in rules/active.list...
+ svn commit -m 'promotions validated' rules/active.list
Sending rules/active.list
Transmitting file data .done
Committing transaction...
Committed revision 1858595.
I'm out of time to keep pursuing this but hoping someone else can look
at it.
Regards,
KAM
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-text-html" lang="x-unicode">
<div class="moz-cite-prefix">Resending with correct dev list :-)</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 5/5/2019 6:10 AM, Paul Stead
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAABBNBFwT2qR2nVT-Q8pPOC7ExFqxrrXNkmeEZpw=_E=2NkPHQ@mail.gmail.com">
<pre class="moz-quote-pre" wrap="">Promotions and tags still seem to be a \
little problematic at the moment. A run of build/mkupdates/listpromotable locally \
shows +300 lines difference to active.list over the one being submitted.</pre>
</blockquote>
<p>Before I deal with this issue:</p>
<p>+Dev.</p>
<p>TL;DR: REMINDER: PLEASE use a make test on your local checkout
before committing!</p>
<p>We had two issues. It appears an svn commit failed on a
release and that left cruft that was colliding for commit. That
issue was caused by a manual edit to active.list:</p>
<p>Revision <a
href="http://svn.apache.org/viewvc?view=revision&revision=1854477"><strong>1854477</strong></a>
- (<a
href="http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?revision=1854477&view=markup">view</a>)
(<a
href="http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?revision=1854477&view=co">download</a>)
(<a
href="http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?annotate=1854477">annotate</a>)
- <a
href="http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?view=log&r1=1854477">[select
for diffs]</a> <br>
Modified <em>Wed Feb 27 18:16:20 2019 UTC</em> (2 months ago)
by <em>gbechis</em> <br>
File length: 15052 byte(s) <br>
Diff to <a
href="http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?r1=1854447&r2=1854477">previous
1854447</a> (<a
href="http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?r1=1854447&r2=1854477&diff_format=h">colored</a>)
</p>
<pre class="vc_log">Switch to https and fix some 404 errors
bz #7652
</pre>
<p>The second issue is a continuing one and that is committers
submitting without 'make test' first. This occurred in January
when I tried to build the last release. If the svn for trunk
including rules is broken, it will break masscheck, etc. We are
currently passing again so just a friendly reminder. It takes a
village to stop a spammer :-)</p>
<p><br>
</p>
<p>So now, what I see in the logs is that the commit didn't occur
but there is no error, nothing. Checking
<a class="moz-txt-link-freetext"
href="http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?view=log">http://svn.apache.org/viewvc/spamassassin/trunk/rules/active.list?view=log</a>
concurs:<br>
</p>
<p>5/5 (note that Committing promotions is NOT followed by an svn
commit)<br>
</p>
<pre class="moz-quote-pre" wrap="">+ echo 'Committing promotions in \
rules/active.list...' + svn commit -m 'promotions validated' rules/active.list
Committing promotions in rules/active.list...
+ /usr/bin/perl masses/rule-qa/list-bad-rules</pre>
<pre class="moz-quote-pre" wrap="">5/4 (example where the commit worked)
+ echo 'Committing promotions in rules/active.list...'
Committing promotions in rules/active.list...
+ svn commit -m 'promotions validated' rules/active.list
Sending rules/active.list
Transmitting file data .done
Committing transaction...
Committed revision 1858595.
</pre>
<p><br>
I'm out of time to keep pursuing this but hoping someone else
can look at it.<br>
</p>
<p>Regards,</p>
<p>KAM<br>
</p>
<p><br>
</p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic