[prev in list] [next in list] [prev in thread] [next in thread]
List: spamassassin-devel
Subject: Re: [Bug 7087] Smaller HIT rate because of changes that affects URIBL
From: "Kevin A. McGrail" <KMcGrail () PCCC ! com>
Date: 2014-10-06 13:14:58
Message-ID: 543295D2.5030405 () PCCC ! com
[Download RAW message or body]
Thanks Rafal,
FYI that I cleaned up your patch and committed it to trunk. It's a
trivial patch that doesn't require a CLA because you really added one if
loop and some documentation. However, if you could get a CLA on file
for the ASF, it would help greatly if you submit anything more complex.
Please see www.apache.org/licenses/#clas
Regards,
KAM
On 10/6/2014 4:51 AM, bugzilla-daemon@issues.apache.org wrote:
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7087
>
> --- Comment #13 from Rafal Ramocki <rafal.ramocki@eo.pl> ---
> Created attachment 5245
> --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=5245&action=edit
> patch adding optional re-enabling searching dkim headers for uris.
>
> AXB: It is not about hacking URIBL plugin as it's code will remain intact.
> Changing this will make uris available not only for URIDNSBL but also for other
> rules (like "uri * /pattern/")
>
> Kevin: I think about the same approach as You described. Please find an
> attachment for adding option. I don't now if this name for it is acceptable. I
> didn't found in code documentation pointed ind bug #6700 and available:
>
> http://wiki.apache.org/spamassassin/WritingRules
>
> So patch doesn't contain changes in this text. I suppose that this is rather
> part of site than doc's. Below is change proposal;
>
> URI rules
>
> URI rules are very simple, normaly they only match text in the URI's contained
> in plain text and HTML sections of mail. This is very handy for searching for
> links containing spam advertised sites.
>
> For example This rule will look for web links to www.example.com/OrderViagra/
>
> uri LOCAL_URI_EXAMPLE /www\.example\.com\/OrderViagra\//
> score LOCAL_URI_EXAMPLE 0.1
>
> Setting parse_dkim_uris to 1 (disabled by default) will additionaly try to
> match pattern against domain in DKIM header if it exists.
>
> I'm open for feedback and Your opinions.
>
> best regards
> Rafal Ramocki
>
--
*Kevin A. McGrail*
President
Peregrine Computer Consultants Corporation
3927 Old Lee Highway, Suite 102-C
Fairfax, VA 22030-2422
http://www.pccc.com/
703-359-9700 x50 / 800-823-8402 (Toll-Free)
703-798-0171 (wireless)
KMcGrail@PCCC.com <mailto:kmcgrail@pccc.com>
[Attachment #3 (multipart/related)]
[Attachment #5 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Thanks Rafal,<br>
<br>
FYI that I cleaned up your patch and committed it to trunk. It's
a trivial patch that doesn't require a CLA because you really
added one if loop and some documentation. However, if you could
get a CLA on file for the ASF, it would help greatly if you submit
anything more complex. Please see <a class="moz-txt-link-abbreviated" \
href="http://www.apache.org/licenses/#clas">www.apache.org/licenses/#clas</a><br> \
<br> Regards,<br>
KAM<br>
<br>
On 10/6/2014 4:51 AM, <a class="moz-txt-link-abbreviated" \
href="mailto:bugzilla-daemon@issues.apache.org">bugzilla-daemon@issues.apache.org</a> \
wrote:<br> </div>
<blockquote
cite="mid:bug-7087-26-bJXaS3cXYz@https.issues.apache.org%2FSpamAssassin%2F"
type="cite">
<pre wrap=""><a class="moz-txt-link-freetext" \
href="https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7087">https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7087</a>
--- Comment #13 from Rafal Ramocki <a class="moz-txt-link-rfc2396E" \
href="mailto:rafal.ramocki@eo.pl"><rafal.ramocki@eo.pl></a> --- Created \
attachment 5245
--> <a class="moz-txt-link-freetext" \
href="https://issues.apache.org/SpamAssassin/attachment.cgi?id=5245&action=edit">https://issues.apache.org/SpamAssassin/attachment.cgi?id=5245&action=edit</a>
patch adding optional re-enabling searching dkim headers for uris.
AXB: It is not about hacking URIBL plugin as it's code will remain intact.
Changing this will make uris available not only for URIDNSBL but also for other
rules (like "uri * /pattern/")
Kevin: I think about the same approach as You described. Please find an
attachment for adding option. I don't now if this name for it is acceptable. I
didn't found in code documentation pointed ind bug #6700 and available:
<a class="moz-txt-link-freetext" \
href="http://wiki.apache.org/spamassassin/WritingRules">http://wiki.apache.org/spamassassin/WritingRules</a> \
So patch doesn't contain changes in this text. I suppose that this is rather
part of site than doc's. Below is change proposal;
URI rules
URI rules are very simple, normaly they only match text in the URI's contained
in plain text and HTML sections of mail. This is very handy for searching for
links containing spam advertised sites.
For example This rule will look for web links to <a class="moz-txt-link-abbreviated" \
href="http://www.example.com/OrderViagra/">www.example.com/OrderViagra/</a>
uri LOCAL_URI_EXAMPLE /www\.example\.com\/OrderViagra\//
score LOCAL_URI_EXAMPLE 0.1
Setting parse_dkim_uris to 1 (disabled by default) will additionaly try to
match pattern against domain in DKIM header if it exists.
I'm open for feedback and Your opinions.
best regards
Rafal Ramocki
</pre>
</blockquote>
<br>
<br>
<div class="moz-signature">-- <br>
<b>Kevin A. McGrail</b><br>
President
<p>
Peregrine Computer Consultants Corporation<br>
3927 Old Lee Highway, Suite 102-C<br>
Fairfax, VA 22030-2422</p>
<p>
<a href="http://www.pccc.com/">http://www.pccc.com/</a></p>
<p>
703-359-9700 x50 / 800-823-8402 (Toll-Free)<br>
703-798-0171 (wireless)<br>
<a href="mailto:kmcgrail@pccc.com">KMcGrail@PCCC.com</a></p>
<p>
</p>
<div align="center"><img
src="cid:part3.05070509.03070505@PCCC.com"></div>
</div>
</body>
</html>
["pccc_logo.gif" (image/gif)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic