[prev in list] [next in list] [prev in thread] [next in thread] 

List:       spamassassin-devel
Subject:    Re: [Bug 4124]  New: New spamassassin script doesn't work due to  tainting
From:       "Malte S. Stretz" <msquadrat.nospamplease () gmx ! net>
Date:       2005-02-16 18:36:40
Message-ID: 200502161936.41853 () malte ! stretz ! eu ! org
[Download RAW message or body]

On Wednesday 16 February 2005 19:26 CET Daniel Quinlan wrote:
> Sidney Markowitz <sidney@sidney.com> writes:
> > Malte, the current makefile is broken for Windows in one place.
> >
> > Line 1152 of Makefile.PL has
> >
> > ifeq "$(INSTALLDIRS)" "site"
> > INSTALLSCRIPTREALLY = $(INSTALLSITEBIN)
> > else
> > INSTALLSCRIPTREALLY = $(INSTALLSCRIPT)
> > endif
> >
> > In Windows we use nmake instead of GNU make, which has different
> > conditional syntax:
> >
> > !IF "$(INSTALLDIRS)" == "site"
> > INSTALLSCRIPTREALLY = $(INSTALLSITEBIN)
> > !ELSE
> > INSTALLSCRIPTREALLY = $(INSTALLSCRIPT)
> > !ENDIF
>
> We support nmake?
>
> Anyway, I added those lines.  Is there a way to conditionalize that
> without ifeq or !if ?

Yeah, don't do it in the Makefile :)  I forgot to commit the fix I have 
here, will do so later on.

Cheers,
Malte

-- 
[SGT] Simon G. Tatham: "How to Report Bugs Effectively"
      <http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>
[ESR] Eric S. Raymond: "How To Ask Questions The Smart Way"
      <http://www.catb.org/~esr/faqs/smart-questions.html>
[prev in list] [next in list] [prev in thread] [next in thread]