[prev in list] [next in list] [prev in thread] [next in thread] 

List:       spamassassin-devel
Subject:    [SAdev] [Bug 1997] New: Makefile.PL should query re: Razor before building Makefile
From:       bugzilla-daemon () hughes-family ! org
Date:       2003-05-31 0:17:51
[Download RAW message or body]

http://www.hughes-family.org/bugzilla/show_bug.cgi?id=1997

           Summary: Makefile.PL should query re: Razor before building
                    Makefile
           Product: Spamassassin
           Version: 2.55
          Platform: Other
               URL: http://marc.theaimsgroup.com/?l=spamassassin-
                    talk&m=105402564419609&w=2
        OS/Version: other
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: unix-packaging
        AssignedTo: spamassassin-devel@lists.sourceforge.net
        ReportedBy: gary@intrepid.com


The "problem" is that "perl Makefile.PL" at first glance, seems to terminate
unexpectedly after asking the user whether to configure in Razor2 or not.
The user dialog looks like this:

% perl Makefile.PL
Writing Makefile for Mail::SpamAssassin
Run Razor v2 tests (these may fail due to network problems)? (y/n) [n] y

The quick exit after receiving the answer to the Razor2 question can give
the user the impression that nothing actually happened. In fact, the program
will create a t/do_razor2 file if the user types "y"(yes), and then exit.

  $do =~ tr/y1/0/c;

  unlink("t/do_razor${v}");
  if ($do) {
    open(FLAG, ">t/do_razor${v}") && close(FLAG);
  }

Maybe better would be to move this code ahead of the block that actually builds
the makefile. Then, the dialog looks as follows:

% perl Makefile.PL
Run Razor v2 tests (these may fail due to network problems)? (y/n) [n] y
Writing Makefile for Mail::SpamAssassin

which is probably something more like the user was expecting. The code is doing
the same thing, but concludes with the comforting note about the Makefile
having been made.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


-------------------------------------------------------
This SF.net email is sponsored by: eBay
Get office equipment for less on eBay!
http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
_______________________________________________
Spamassassin-devel mailing list
Spamassassin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spamassassin-devel
[prev in list] [next in list] [prev in thread] [next in thread]