[prev in list] [next in list] [prev in thread] [next in thread] 

List:       spacewalk-devel
Subject:    Re: [Spacewalk-devel] API date inconsistency : channel.software.listErrata
From:       Miroslav_Suchý <msuchy () redhat ! com>
Date:       2012-02-14 10:59:18
Message-ID: 4F3A3E86.9030206 () redhat ! com
[Download RAW message or body]

On 02/14/2012 10:24 AM, Steven Hardy wrote:
> Planning to raise a Bz for this issue, but wanted to post it here for
> comments first.
>
> So the problem is the channel.software.listErrata calls handle dates
> inconsistently, with some using the errata issue date (which is what I
> expect unless explicitly mentioned otherwise in the docs), and others
> interpreting arguments (and returning dates) based on the last
> *modified*  date, which obviously may change so is not a good key for
> selecting errata.
>
> Specifically:
>
> <snip from the API docs>
> Method: listErrata
> Description:
> List the errata applicable to a channel between startDate and endDate.
>
> Parameters:
>        * string sessionKey
>        * string channelLabel - channel to query
>        * dateTime.iso8601 startDate
>        * dateTime.iso8601 endDate
>
> Returns:
>        * array:
>                * struct - errata
>                        * int "id" - Errata ID.
>                        * string "date" - Date erratum was created.
>                        * string "advisory_synopsis" - Summary of the
>                          erratum.
>                        * string "advisory_type" - Type label such as
>                          Security, Bug Fix
>                        * string "advisory_name" - Name such as RHSA, etc
> </snip>
>
> AFAICT this call is broken - it says that the returned "date" field is
> the date the erratum was created, but this is a lie - it's really the
> date the errata was*last modified*.

I did not tried to reproduce it, but yes  I see it in code. True. You 
find that we are lying, then feel free to fix it :)

-- 
Miroslav Suchy
Red Hat Satellite Engineering

[prev in list] [next in list] [prev in thread] [next in thread]