[prev in list] [next in list] [prev in thread] [next in thread] 

List:       spacewalk-devel
Subject:    Re: [Spacewalk-devel] [PATCH] filename stays the same when kickstart is renamed
From:       Tomas Lestach <tlestach () redhat ! com>
Date:       2011-12-09 16:45:51
Message-ID: 1925483.YeaLAq5QSN () tml ! usersys ! redhat ! com
[Download RAW message or body]

On Thursday 08 of December 2011 15:18:14 Uwe Gansert wrote:
> On 07.12.2011 17:37, Tomas Lestach wrote:
> > I see your problem.
> > I want to ask, what led you to your solution and why didn't you just
> > store/update the file, when a kickstrat gets renamed?
> > 
> > Sorry, it took me that long to check your patch.
> 
> it might well be that there is a better way to solve that.
> Like I said, I'm not 100% happy with that patch either but I did not see
> a better way. I just used eclipse to debug what happens when you change
> the name of a profile.
> I don't know the code so well, so maybe I overlooked something that you
> can clearly see :)
> If you have a nice fix for that, I'd be happy to revert my patch here
> and use yours :)

Hello Uwe,

I'm not sure it is a nice patch, but I'd prefer following solution:
spacewalk.git: 95785c4cf354522073e5a518446e47c261665d37

I have to admit the cobbler interface isn't a nice part of spacewalk code. :-)
Anyway, I thank you for reproting the bug and for your efforts.

Best Regards,
Tomas
--
Tomas Lestach
RHN Satellite Engineering, Red Hat

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic