[prev in list] [next in list] [prev in thread] [next in thread] 

List:       spacewalk-devel
Subject:    [Spacewalk-devel] [PATCH/RFC] manage symlinks in config management
From:       cperry () redhat ! com (Cliff)
Date:       2009-09-03 1:29:48
Message-ID: 4A9F1C0C.4060301 () redhat ! com
[Download RAW message or body]

Michael Mraka wrote:
> Joshua Roys wrote:
>>> Hello all,
>>>
>>> Attached is a patch that fills out the previous effort.  Diffs to
>>> deployed files now work properly.  I added a symlink icon (I used your
>>> existing file icon and basically pasted an icon from gnome on top - I
>>> don't know if that's okay with you all.  The specific file is
>>> /usr/share/icons/gnome/8x8/emblems/emblem-symbolic-link.png.)  Symlinks
>>> are now created in file_utils.py/process, and deployed in the
>>> transactions.py/deploy method, just like files are.
>>>
>>> I also changed setfilecon to lsetfilecon, but left the chown/chmod as
>>> they were and didn't change them over to their lch??? equivalents -
>>> lchmod is only in python 2.6.  Links are usually root:root/0777 anyways.
>>>    The only thing I might still do is add some javascript to grey out the
>>> user/mode fields in the webui.
>>>
>>> Thanks,
>>>
>>> Joshua Roys
>> Hello again,
>>
>> Attached is a diff for git commit --amend.  It fixes 3 typos and adds  
>> the javascript to disable unneeded input fields when the 'symlink' type  
>> is selected in the 'Create File' part of config management.
>>
>> Thanks,
>>
>> Joshua Roys
> 
> Hello Joshua,
> 
> your patch is applied to master. Thanks for contribution ;).
> 
> --
> Michael Mr?ka
> Satellite Engineering, Red Hat
> 
> _______________________________________________
> Spacewalk-devel mailing list
> Spacewalk-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel

Thanks Michael for applying and Josh for the code! :)

Cliff



[prev in list] [next in list] [prev in thread] [next in thread]