[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sox-devel
Subject:    Re: [SoX-devel] [ sox-Bugs-3476843 ] Invalid memory access within flac handler after seek
From:       Eric Wong <normalperson () yhbt ! net>
Date:       2012-05-26 19:44:19
Message-ID: 20120526194419.GA27689 () dcvr ! yhbt ! net
[Download RAW message or body]

Ulrich Klauer <ulrich@chirlu.de> wrote:
> Eric Wong <normalperson@yhbt.net>:
> 
> > I believe I have a fix for this issue, I can't figure out how to attach a
> > patch, but you should be able to curl this to "git am"
> > http://bogomips.org/sox.git/patch/?id=d469441154331de90df5bd0366fe4fd07b65535a
> 
> Looks good and makes my test case work. I've just pushed it to dot  
> (14.4.1-to-be). Thanks!

No problem!

Btw, read_samples() doesn't have to return the requested size, just some
value >0 to prevent signaling EOF, right?  After some seek points, the
handler enters the malloc + (memmove|memcpy) code path and seems to
stay there (until EOF) because alignment is off from the original FLAC
stream

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

[prev in list] [next in list] [prev in thread] [next in thread]