[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sonar-dev
Subject:    Re: [sonar-dev] violation due to 'throws Throwable' in AOP around advice
From:       Freddy Mallet <freddy.mallet () gmail ! com>
Date:       2013-05-20 11:56:34
Message-ID: CAPyGxig7teDDQGLh+UpkG=fKdAWzmfLh2nhW2Z8XC+0Q3Rn73g () mail ! gmail ! com
[Download RAW message or body]

Hi Lars,

Please this email should have been sent to the user mailing list and not to
the dev one.

Could you deeply define the expected behaviour ? Is it something like : "As
soon a method is impacted by AspectJ, the rule should be deactivated as it
becomes irrelevant in such context" ?

Thanks

-----
twitter.com/FreddyMallet
Sonar for Continuous Inspection


On Fri, May 17, 2013 at 1:57 PM, Lars Gohlke <
lars.gohlke@immobilienscout24.de> wrote:

> Hi community,
>
> I'm wondering why sonar does not accept
>
>
> @Aspect
> ...
> public class TimeMeasurementAspect {
>
>  [...]
>
>   @Around("**ourTimeMeasurementMethods()")
>   public Object doBasicProfiling(**ProceedingJoinPoint pjp) throws
> Throwable {
>     [...]
>   }
> }
>
> see: https://github.com/**ImmobilienScout24/yum-repo-**
> server/blob/master/src/main/**java/de/is24/infrastructure/**
> gridfs/http/monitoring/**TimeMeasurementAspect.java#L40<https://github.co=
m/ImmobilienScout24/yum-repo-server/blob/master/src/main/java/de/is24/infra=
structure/gridfs/http/monitoring/TimeMeasurementAspect.java#L40>
>
> In my opinion this is a special case to be allowed.
>
> What is your opinions?
>
> rule: checkstyle : com.puppycrawl.tools.**checkstyle.checks.coding.**
> IllegalThrowsCheck
>
> cheers Lars
> --
>
> ------------------------------**----------------------------
> Immobilien Scout GmbH
> Aufsichtsrat: Dr. Martin Enderle (Vorsitzender)
> Gesch=C3=A4ftsf=C3=BChrer: Dirk Hoffmann, Marc Stilke (Sprecher)
> Handelsregister: Amtsgericht Charlottenburg, HRB 69108
> Sitz der Gesellschaft: Berlin
> ------------------------------**----------------------------
>
> ------------------------------**------------------------------**---------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/**manage_email<http://xircles.codehaus.org=
/manage_email>
>
>
>

[Attachment #3 (text/html)]

<div dir="ltr">Hi Lars,<div><br></div><div style>Please this email should have been \
sent to the user mailing list and not to the dev one.  </div><div \
style><br></div><div style>Could you deeply define the expected behaviour ? Is it \
something like : &quot;As soon a method is impacted by AspectJ, the rule should be \
deactivated as it becomes irrelevant in such context&quot; ?</div> <div \
style><br></div><div style>Thanks</div></div><div class="gmail_extra"><br \
clear="all"><div><div><span \
style="font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">-----</span></div><div><a \
href="https://twitter.com/FreddyMallet" \
style="font-family:arial,sans-serif;background-color:rgb(255,255,255)" \
target="_blank">twitter.com/FreddyMallet</a></div> <div><span \
style="background-color:rgb(255,255,255)">Sonar for Continuous \
Inspection</span></div></div> <br><br><div class="gmail_quote">On Fri, May 17, 2013 \
at 1:57 PM, Lars Gohlke <span dir="ltr">&lt;<a \
href="mailto:lars.gohlke@immobilienscout24.de" \
target="_blank">lars.gohlke@immobilienscout24.de</a>&gt;</span> wrote:<br> \
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi community,<br> <br>
I&#39;m wondering why sonar does not accept<br>
<br>
<br>
@Aspect<br>
...<br>
public class TimeMeasurementAspect {<br>
<br>
  [...]<br>
<br>
   @Around(&quot;<u></u>ourTimeMeasurementMethods()&quot;)<br>
   public Object doBasicProfiling(<u></u>ProceedingJoinPoint pjp) throws Throwable \
{<br>  [...]<br>
   }<br>
}<br>
<br>
see: <a href="https://github.com/ImmobilienScout24/yum-repo-server/blob/master/src/mai \
n/java/de/is24/infrastructure/gridfs/http/monitoring/TimeMeasurementAspect.java#L40" \
target="_blank">https://github.com/<u></u>ImmobilienScout24/yum-repo-<u></u>server/blo \
b/master/src/main/<u></u>java/de/is24/infrastructure/<u></u>gridfs/http/monitoring/<u></u>TimeMeasurementAspect.java#L40</a><br>


<br>
In my opinion this is a special case to be allowed.<br>
<br>
What is your opinions?<br>
<br>
rule: checkstyle : com.puppycrawl.tools.<u></u>checkstyle.checks.coding.<u></u>IllegalThrowsCheck<br>
 <br>
cheers Lars<br>
-- <br>
<br>
------------------------------<u></u>----------------------------<br>
Immobilien Scout GmbH<br>
Aufsichtsrat: Dr. Martin Enderle (Vorsitzender)<br>
Geschäftsführer: Dirk Hoffmann, Marc Stilke (Sprecher)<br>
Handelsregister: Amtsgericht Charlottenburg, HRB 69108<br>
Sitz der Gesellschaft: Berlin<br>
------------------------------<u></u>----------------------------<br>
<br>
------------------------------<u></u>------------------------------<u></u>---------<br>
 To unsubscribe from this list, please visit:<br>
<br>
     <a href="http://xircles.codehaus.org/manage_email" \
target="_blank">http://xircles.codehaus.org/<u></u>manage_email</a><br> <br>
<br>
</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]