[prev in list] [next in list] [prev in thread] [next in thread]
List: solr-dev
Subject: Re: Custom Solr Collector
From: Kyle Maxwell <kyle.maxwell () reddit ! com ! INVALID>
Date: 2020-02-13 20:45:37
Message-ID: E8B2CA1B-17F6-4642-99E0-77BFEF730BBB () reddit ! com
[Download RAW message or body]
You understand the min-visited part.
I don't think the EarlyTerminatingSortingCollector is exactly what we want because we \
don't want to sort the query results, just scan the index in roughly sorted order and \
score normally.
Thankfully, a bunch of the features I've written custom collectors for over the years \
have made it into Solr by now, so maybe the full arbitrary collector configuration is \
overkill.
> On Feb 13, 2020, at 11:42 AM, Tomás Fernández Löbbe <tomasflobbe@gmail.com> \
> wrote:
>
> Hi Kyle,
> For #2, I understand you need this because you want "min-visited-docs", right? \
> Because, for max you could use EarlyTerminatingSortingCollector? (or Lucene's \
> "HitsThresholdChecker", but I don't know if Solr has support for this yet). The \
> "min-visited" would override the "timeAllowed", so even if the collection should \
> expire based on time, you'd let it continue until something hits, is that the idea? \
>
> > On Thu, Feb 13, 2020 at 9:29 AM Kyle Maxwell <kyle.maxwell@reddit.com.invalid> \
> > wrote: Hi,
> > Looking to see if there's any appetite for either:
> >
> > 1. Allowing custom collectors as Solr Plugins, or
> > 2. Taking a patch on TimeLimitedCollector to allow it to be doc-limited as well.
> >
> > Motivation:
> > https://medium.com/@kyle.c.maxwell/some-lucene-tuning-t-45d82a9dfd83
> >
> > TimeLimitedCollector Patch:
> > https://github.com/fizx/lucene-solr-1/pull/1/files
> >
> > Which approach might people prefer? I'm happy to do the legwork, but wanted to \
> > check in first.
> > Thanks,
> > Kyle
[Attachment #3 (text/html)]
<html><head><meta http-equiv="content-type" content="text/html; \
charset=utf-8"></head><body dir="auto">You understand the min-visited \
part.<div><br></div><div>I don't think the EarlyTerminatingSortingCollector is \
exactly what we want because we don't want to sort the query results, just scan the \
index in roughly sorted order and score \
normally. </div><div><br></div><div>Thankfully, a bunch of the features I've \
written custom collectors for over the years have made it into Solr by now, so maybe \
the full arbitrary collector configuration is overkill.<br><div><div \
dir="ltr"><br><blockquote type="cite">On Feb 13, 2020, at 11:42 AM, Tomás Fernández \
Löbbe <tomasflobbe@gmail.com> wrote:<br><br></blockquote></div><blockquote \
type="cite"><div dir="ltr"><div dir="ltr"><div>Hi Kyle,</div><div>For #2, I \
understand you need this because you want "min-visited-docs", right? Because, for max \
you could use EarlyTerminatingSortingCollector? (or Lucene's "HitsThresholdChecker", \
but I don't know if Solr has support for this yet). The "min-visited" would override \
the "timeAllowed", so even if the collection should expire based on time, you'd let \
it continue until something hits, is that the idea?<br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 13, 2020 at 9:29 AM \
Kyle Maxwell <kyle.maxwell@reddit.com.invalid> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div>Looking to see if there's \
any appetite for either:</div><div><br></div><div>1. Allowing custom collectors as \
Solr Plugins, or</div><div>2. Taking a patch on TimeLimitedCollector to allow it to \
be doc-limited as well.</div><div><br></div><div>Motivation:</div><div><a \
href="https://medium.com/@kyle.c.maxwell/some-lucene-tuning-t-45d82a9dfd83" \
target="_blank">https://medium.com/@kyle.c.maxwell/some-lucene-tuning-t-45d82a9dfd83</a><br></div><div><br></div><div>TimeLimitedCollector \
Patch:</div><div><a href="https://github.com/fizx/lucene-solr-1/pull/1/files" \
target="_blank">https://github.com/fizx/lucene-solr-1/pull/1/files</a><br></div><div><br></div><div>Which \
approach might people prefer? I'm happy to do the legwork, but wanted to check \
in first.</div><div><br></div><div>Thanks,</div><div>Kyle<br></div></div> \
</blockquote></div> </div></blockquote></div></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic