[prev in list] [next in list] [prev in thread] [next in thread] 

List:       solr-dev
Subject:    [jira] (SOLR-10080) Fix some issues reported by findbugs
From:       "Michael Braun (JIRA)" <jira () apache ! org>
Date:       2017-01-31 21:55:51
Message-ID: JIRA.13039300.1485897662000.2992.1485899751846 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/SOLR-10080?page=com.atlassian.jira.plugin. \
system.issuetabpanels:comment-tabpanel&focusedCommentId=15847585#comment-15847585 ] 

Michael Braun commented on SOLR-10080:
--------------------------------------

In BlobRepository the only use of that synchronized call I can see on first glance \
would be to prevent blobCreator.call from executing twice, but the same thing can be \
accomplished by using .computeIfAbsent. 

> Fix some issues reported by findbugs 
> -------------------------------------
> 
> Key: SOLR-10080
> URL: https://issues.apache.org/jira/browse/SOLR-10080
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public) 
> Reporter: Pushkar Raste
> Priority: Minor
> Attachments: SOLR-10080.patch
> 
> 
> I ran a findbugs analysis on code and found a lot of issues. I found issues in both \
> lucene and solr, however, I am not sure whether Solr developers should fix issues \
> like this in the lucene code or not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]