[prev in list] [next in list] [prev in thread] [next in thread]
List: solr-dev
Subject: Re: Solr Config MergePolicy/MergeScheduler Naming Bug?
From: Mike Drob <madrob () cloudera ! com>
Date: 2015-06-30 21:16:11
Message-ID: CAFAMeYLTheBz5nyZWAMtBog827xEJy04PZSRYFjcD_uxjeKOVQ () mail ! gmail ! com
[Download RAW message or body]
https://issues.apache.org/jira/browse/SOLR-7741
On Tue, Jun 30, 2015 at 3:57 PM, Mike Drob <madrob@cloudera.com> wrote:
> It looks like this toMap method is only used (transitively) by
> SolrConfigHandler.handleGet to print the config and show it to a client.
> Probably safe to add the other elements as well, good catch.
>
> On Tue, Jun 30, 2015 at 3:49 PM, Christine Poerschke (BLOOMBERG/ LONDON) <
> cpoerschke@bloomberg.net> wrote:
>
> > Hi,
> >
> > Follow-on question, also re: SolrIndexConfig's toMap method. The
> > constructor reads "/mergedSegmentWarmer" and "/infoStream" and
> > "/infoStream/@file" elements but the toMap method does not write them.
> >
> > Would that be intended or is it maybe an unintended omission? If intended
> > would be great to have a comment in toMap to clarify why/which elements are
> > skipped, so that if/when a new element is added its easier to determine if
> > toMap should write the new element also.
> >
> > Happy to open a JIRA with a patch, or to add to Mike's JIRA/patch.
> >
> > Christine
> >
> > From: dev@lucene.apache.org At: Jun 30 2015 21:03:19
> > To: dev@lucene.apache.org
> > Subject: Re:Solr Config MergePolicy/MergeScheduler Naming Bug?
> >
> > Concur, that looks like a copy/paste bug. The JIRA(s) associated with the
> > commit are no longer open, so a new JIRA with the one-line patch would seem
> > the next logical step. This appears to affect trunk but not branch_5x or
> > branch_4x. Well spotted!
> >
> > From: dev@lucene.apache.org At: Jun 30 2015 20:34:48
> > To: dev@lucene.apache.org <#14e464282ffbd6ff_14e463b75da28f90_>
> > Subject: Re:Solr Config MergePolicy/MergeScheduler Naming Bug?
> >
> > I was looking through code for unrelated reasons and this line stuck out
> > to me:
> >
> >
> > https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L180
> >
> > if(mergeSchedulerInfo != null) \
> > m.put("mergeScheduler",mergeSchedulerInfo.toMap()); if(mergePolicyInfo != null) \
> > m.put("mergeScheduler",mergePolicyInfo. toMap());
> >
> > Are they both supposed to be using the "mergeScheduler" key? If not,
> > happy to open a JIRA and provide the one-line patch.
> >
> > Mike
> >
> >
>
[Attachment #3 (text/html)]
<div dir="ltr"><a href="https://issues.apache.org/jira/browse/SOLR-7741">https://issues.apache.org/jira/browse/SOLR-7741</a><br></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 30, 2015 at 3:57 PM, \
Mike Drob <span dir="ltr"><<a href="mailto:madrob@cloudera.com" \
target="_blank">madrob@cloudera.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div>It looks like this toMap method is only \
used (transitively) by SolrConfigHandler.handleGet to print the config and show it \
to a client. Probably safe to add the other elements as well, good \
catch.<br></div></div><div class="HOEnZb"><div class="h5"><div \
class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 30, 2015 at 3:49 PM, \
Christine Poerschke (BLOOMBERG/ LONDON) <span dir="ltr"><<a \
href="mailto:cpoerschke@bloomberg.net" \
target="_blank">cpoerschke@bloomberg.net</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div><div \
style="white-space:pre-wrap;font-size:small;font-family:'Courier \
New',Courier;color:rgb(0,0,0)">Hi,<div><br></div><div>Follow-on question, also \
re: SolrIndexConfig's toMap method. The constructor reads \
"/mergedSegmentWarmer" and "/infoStream" and \
"/infoStream/@file" elements but the toMap method does not write \
them.</div><div><br></div><div>Would that be intended or is it maybe an unintended \
omission? If intended would be great to have a comment in toMap to clarify why/which \
elements are skipped, so that if/when a new element is added its easier to determine \
if toMap should write the new element also.</div><div><br></div><div>Happy to open a \
JIRA with a patch, or to add to Mike's \
JIRA/patch.</div><div><br></div><div>Christine</div><div \
style="font-size:small;font-family:'Courier \
New',Courier;color:rgb(0,0,0)"><br><div><div>From: <a \
href="mailto:dev@lucene.apache.org" target="_blank">dev@lucene.apache.org</a> At: Jun \
30 2015 21:03:19</div><span><div>To: <a href="mailto:dev@lucene.apache.org" \
target="_blank">dev@lucene.apache.org</a><br>Subject: Re:Solr Config \
MergePolicy/MergeScheduler Naming Bug?<br></div></span></div><span><div \
style="color:black;font-family:Arial,'BB.Proportional';font-size:small;white-s \
pace:normal;background-color:white;background-repeat:initial"><div><blockquote><div \
style="white-space:pre-wrap;font-size:small;font-family:'Courier \
New',Courier;color:rgb(0,0,0)">Concur, that looks like a copy/paste bug. The \
JIRA(s) associated with the commit are no longer open, so a new JIRA with the \
one-line patch would seem the next logical step. This appears to affect trunk but not \
branch_5x or branch_4x. Well spotted!<br><div \
style="font-size:small;font-family:'Courier \
New',Courier;color:rgb(0,0,0)"><br><div><div>From: <a \
href="mailto:dev@lucene.apache.org" target="_blank">dev@lucene.apache.org</a> At: Jun \
30 2015 20:34:48</div><div>To: <a \
href="#14e464282ffbd6ff_14e463b75da28f90_">dev@lucene.apache.org</a><br>Subject: \
Re:Solr Config MergePolicy/MergeScheduler Naming Bug?<br></div></div><div \
style="color:black;font-family:Arial,'BB.Proportional';font-size:small;white-s \
pace:normal;background-color:white;background-repeat:initial"><div><blockquote><div \
dir="ltr">I was looking through code for unrelated reasons and this line stuck out to \
me:<br><div><br><a href="https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L180" \
target="_blank">https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/or \
g/apache/solr/update/SolrIndexConfig.java#L180</a><br><br><span>if</span>(mergeSchedulerInfo \
<span>!=</span> <span>null</span>) \
m<span>.</span>put(<span><span>"</span>mergeScheduler<span>"</span></span>,mergeSchedulerInfo<span>.</span>toMap()); \
<span>if</span>(mergePolicyInfo <span>!=</span> <span>null</span>) \
m<span>.</span>put(<span><span>"</span>mergeScheduler<span>"</span></span>,mergePolicyInfo<span>.</span>toMap());<br><br></div><div>Are \
they both supposed to be using the "mergeScheduler" key? If not, happy to \
open a JIRA and provide the one-line \
patch.<br><br></div><div>Mike<br></div></div></blockquote></div></div></div></div></blockquote></div></div></span></div></div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic