[prev in list] [next in list] [prev in thread] [next in thread] 

List:       solr-dev
Subject:    [jira] [Updated] (LUCENE-5196) Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE
From:       "Shai Erera (JIRA)" <jira () apache ! org>
Date:       2013-08-31 6:02:51
Message-ID: JIRA.12666446.1377926223466.64415.1377928971591 () arcas
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/LUCENE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Shai Erera updated LUCENE-5196:
-------------------------------

    Attachment: LUCENE-5196.patch

More formats respect impersonation. But with this 'ant test  -Dtestcase=TestCodecs \
-Dtests.method=testDisableImpersonation -Dtests.seed=62DBD22C772F3E85' the test \
fails. What I see is that Lucene41RWCodec is used, and it succeeds to write a \
posting. The reason is that Lucene41PostingsFormat is the latest and so still \
'valid'. But it's confusing that Lucene41Codec can be used to write postings, yet not \
DocValues, just because the postings format hasn't changed. Is that a bug or should I \
modify the test to allow "Lucene41" and "Lucene42" to write postings?  
> Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE
> ------------------------------------------
> 
> Key: LUCENE-5196
> URL: https://issues.apache.org/jira/browse/LUCENE-5196
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/test
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Attachments: LUCENE-5196.patch, LUCENE-5196.patch
> 
> 
> This constant is currently not used and from what I understand, it was used in the \
> past to test 3.x stuff? Anyway, I want to revive it by renaming it to \
> OLD_FORMAT_IMPERSONATION_IS_ACTIVE (defaults to true) and have the RWCodecs respect \
> it by not supporting e.g. fieldsConsumer() if it's set to false. This will allow \
> tests that want to verify e.g. old formats are not supported work. Currently it's \
> impossible because the RWCodec gets loaded before the non-RW by SPI, and so writing \
> segments in an old format always work. I want to test something like that in \
> LUCENE-5189 and prevents it. Will post a patch soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]