[prev in list] [next in list] [prev in thread] [next in thread] 

List:       solr-dev
Subject:    [jira] [Resolved] (LUCENE-4449) Factor TestPostingsFormat into BasePostingsFormatTestCase (or simila
From:       "Robert Muir (JIRA)" <jira () apache ! org>
Date:       2012-09-29 17:16:07
Message-ID: 285867430.143400.1348938967517.JavaMail.jiratomcat () arcas
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/LUCENE-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Robert Muir resolved LUCENE-4449.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0
                   4.1

Committed: though I added some TODOs we could improve on in the future.

In my opinion we shouldnt depend on LuceneTestCase's randomization for stuff like \
this: we should test it all explicitly.  
> Factor TestPostingsFormat into BasePostingsFormatTestCase (or similar)
> ----------------------------------------------------------------------
> 
> Key: LUCENE-4449
> URL: https://issues.apache.org/jira/browse/LUCENE-4449
> Project: Lucene - Core
> Issue Type: Sub-task
> Components: general/test
> Reporter: Robert Muir
> Fix For: 4.1, 5.0
> 
> Attachments: LUCENE-4449.patch
> 
> 
> TestPostingsFormat is designed to fail if you have a bug in your postings format.
> But today we just pick a random PF (or mix) and test that: I think instead we \
> should factor this into a base class in test-framework. So this way each codec \
> would extend this test and force their codec to be used to ensure basic coverage. \
> We could still have the "TestPostingsFormat" in core/ that uses the random mix of \
> PFs too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]