[prev in list] [next in list] [prev in thread] [next in thread] 

List:       solr-dev
Subject:    [jira] Commented: (LUCENE-2732) Fix charset problems in XML loading
From:       "Uwe Schindler (JIRA)" <jira () apache ! org>
Date:       2010-10-31 14:21:24
Message-ID: 32081249.162351288534884550.JavaMail.jira () thor
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/LUCENE-2732?page=com.atlassian.jira.plugin \
.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926712#action_12926712 ] 

Uwe Schindler commented on LUCENE-2732:
---------------------------------------

Committed branch 3.x revision: 1029350

Backporting bugfix only to 3.0/2.9!

> Fix charset problems in XML loading in HyphenationCompoundWordTokenFilter (also \
>                 Solr's loader from schema)
> ----------------------------------------------------------------------------------------------------------
>  
> Key: LUCENE-2732
> URL: https://issues.apache.org/jira/browse/LUCENE-2732
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 2.9.4, 3.0.3, 3.1, 4.0
> 
> Attachments: LUCENE-2732.patch, LUCENE-2732.patch
> 
> 
> As said in LUCENE-2731, the handling of XML in HyphenationCompoundWordTokenFilter \
> is broken and breaks XML 1.0 (5th edition) spec totally. You should never supply a \
> Reader to any XML api, unless you have internal character data (e.g. created \
> programmatically). Also you should supply a system id, as resolving external \
> entities does not work. The loader from files is much more broken, it always open \
> the file as a Reader and then passes it to InputSource. Instead it should point \
> filename directly to InputSource. This issue will fix it in trunk and use \
> InputSource in Solr, but will still supply the Reader possibility in previous \
> versions (deprecated).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]