[prev in list] [next in list] [prev in thread] [next in thread] 

List:       solr-dev
Subject:    Re: [jira] Commented: (SOLR-746) Make it possible to omit responseheader
From:       Chris Hostetter <hossman_lucene () fucit ! org>
Date:       2008-09-30 18:34:19
Message-ID: Pine.LNX.4.62.0809301131030.14412 () radix ! cryptio ! net
[Download RAW message or body]


> how about removing the header right before calling the
> QueryResponseWriter.write() ? so that wed do not have to do the check
> in many different places
> 
> We can add one line into SolrDispatchFilter and it should be fine .

if we want to do it as a "core" param (akin to qt, wt, echoHandler, 
& echoParams) then the simlest thing to do is have SolrCore skip the call 
to setResponseHeaderValues ... i was just pointing out that moving that 
call into RequestHandlers isn't back compatible, and it would be possible 
to solve this in the response writers if we felt like it really only made 
sense in certain situations.

But i'm fine with it being a "core" param as well since hte core is what 
currently computes this stuff.

> 
> On Sun, Sep 28, 2008 at 7:41 AM, Hoss Man (JIRA) <jira@apache.org> wrote:
> > 
> > [ https://issues.apache.org/jira/browse/SOLR-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635201#action_12635201 \
> > ]
> > 
> > Hoss Man commented on SOLR-746:
> > -------------------------------
> > 
> > that wouldn't be back compatible for existing users who have written their own \
> > handlers.
> > 
> > the simplest approach would probably be leave SolrCore alone and just modify the \
> > ResponseWriters where we think this would be relevant (json and XML i'm guessing) \
> > to not bother outputting the responseHeader if a certain param is set.
> > 
> > (the time spent in setResponseHeaderValues should be negligable)
> > 
> > > Make it possible to omit responseheader
> > > ---------------------------------------
> > > 
> > > Key: SOLR-746
> > > URL: https://issues.apache.org/jira/browse/SOLR-746
> > > Project: Solr
> > > Issue Type: Improvement
> > > Components: search
> > > Affects Versions: 1.3
> > > Reporter: Noble Paul
> > > Fix For: 1.4
> > > 
> > > 
> > > In a lot of cases we do not actually need the data included in the
> > > header.So we just waste bandwidth, processing to write and read this .
> > > And there are requests where the responses are quite small and too frequent  \
> > > (say for auto-suggest feature) where this overhead is unnecessary
> > > we should add a request parameter omitHeader=true|false . Default
> > > should be false . If it is true let us not send the header itself
> > > http://markmail.org/message/rcobnn4g2qyzygmp
> > 
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> > 
> > 
> 
> 
> 
> -- 
> --Noble Paul
> 



-Hoss


[prev in list] [next in list] [prev in thread] [next in thread]