[prev in list] [next in list] [prev in thread] [next in thread] 

List:       solr-dev
Subject:    Re: [jira] Commented: (SOLR-258) Date based Facets
From:       "Greg Ludington" <gludington () gmail ! com>
Date:       2007-07-31 4:06:00
Message-ID: 6d3e79160707302106u7fa47578v279d5abff0203cab () mail ! gmail ! com
[Download RAW message or body]

I started looking through this, and it looks very nice, though I do
see one slight nit to pick.  I may be reading this incorrectly, but
two parameters in rangeCount appear to be transposed.  In
SimpleFacets.java, the rangeCount method uses:

new ConstantScoreRangeQuery(field,low,high,iHigh,iLow)

but the Lucene javadocs suggest it is actually

new ConstantScoreRangeQuery(field,low,high,iLow,iHigh)

The iLow and iHigh parameters seem to be reversed.

Thanks,
Greg
[prev in list] [next in list] [prev in thread] [next in thread]