[prev in list] [next in list] [prev in thread] [next in thread] 

List:       snap-users
Subject:    (KAME-snap 9413) Re: Some bugs regarding to MLDv2
From:       SUZUKI Shinsuke <suz () kame ! net>
Date:       2006-04-14 1:20:16
Message-ID: x7mzepkl67.wl%suz () alaxala ! net
[Download RAW message or body]

Hi,

>>>>> On Fri, 31 Mar 2006 09:42:44 +0800
>>>>> yjlee@zyxel.com.tw("Yu-Jung Lee")  said:

>   1. After applying the modification, thers's no report is sent upon
>     reception of MLDv2 queries.
The suggested patch has been applied. (mldv2.c rev.1.62)


>   2. For a multicast address record whose reference count is larger
>     than one, the MLD leaving messages are never sent out even all
>     the applications requesting to that multicast group are no
>     longer in the demand. The MLD leaving messages are sent under
>     the condition that the reference count for the corresponding
>     multicast address structure equals one. However, the multicast
>     address record with reference count larger than one is not
>     reduced by one when an application is going to delete the
>     multicast address record.

This is also fixed in a different manner:  (mldv2.c rev.1.63)
     - in freebsd, if_delmulti() must be called irrespective of the
       "final" value or MLD version (see freebsd's in6_addmulti2()).
     - Since if_delmulti() reduces the ifma_refcount, malloc'ed memory
       will be finally freed in the current implementation. So the
       following patch is no longer necessary.

>   in6_free_all_msf_source_list(in6m);
>   ifma->ifma_protospec = NULL;
>   mld_stop_group_timer(in6m);
>   LIST_REMOVE(in6m, in6m_entry);
>   free(in6m->in6m_timer_ch, M_IPMADDR);
>   free(in6m, M_IPMADDR);
>     after line#3135, revision 1.58 to avoid potential memory leak problem.
       

Thanks,
----
SUZUKI, Shinsuke @ KAME Project

[prev in list] [next in list] [prev in thread] [next in thread]