[prev in list] [next in list] [prev in thread] [next in thread] 

List:       snap-users
Subject:    (KAME-snap 9340) mnd / mps
From:       Nicolas DICHTEL <nicolas.dichtel () 6wind ! com>
Date:       2006-02-06 14:37:03
Message-ID: 43E75F0F.3020105 () 6wind ! com
[Download RAW message or body]

Hi all,

IMO there is a little mistake between hpfx_vltime and
hpfx_vlexpire in function hpfxlist_expire_timer().
If right, there is no need to test "hpfx_vlexpire - now"
in case of "if (hpfx_vlexpire <= now)".
Please find enclosed a patch.

Regards,
Nicolas

["y.diff" (text/plain)]

--- shisad-20060206/mnd.c	2006-01-26 09:47:21.000000000 +0100
+++ shisad-20060206-new/mnd.c	2006-02-06 14:51:57.881419516 +0100
@@ -1285,8 +1285,7 @@
 
 		send_mps(hpfx);
 
-		hpfxlist_set_expire_timer(hpfx, 
-			  ((hpfx->hpfx_vltime - now) > 5) ? (hpfx->hpfx_vltime - now):5);
+		hpfxlist_set_expire_timer(hpfx, 5);
 
 		return;
 	}
@@ -1300,7 +1299,7 @@
 
 	/* rate limiting XXX */
 	hpfxlist_set_expire_timer(hpfx, 
-		((hpfx->hpfx_vltime - now) > 5) ? (hpfx->hpfx_vltime - now):5);
+		((hpfx->hpfx_vlexpire - now) > 5) ? (hpfx->hpfx_vlexpire - now):5);
 }
 
 #endif /* MIP_MN */


[prev in list] [next in list] [prev in thread] [next in thread]