[prev in list] [next in list] [prev in thread] [next in thread] 

List:       slide-dev
Subject:    RE: Loading parameters in EmbeddedDomain
From:       "Nevermann, Dr., Peter" <Peter.Nevermann () softwareag ! com>
Date:       2003-01-20 12:03:59
[Download RAW message or body]

Hi Unico,

I have checked-in the changes you proposed. Thank you for your contribution.
The problem has been waiting for a solution for long time now. 

> As I am not aware of all the design issues involved perhaps 
> someone could review these changes and comment on them. If 
> there are no problems with this approach I could prepare a 
> patch if you like.

Neither am I aware of all design issues. As far as I can see, your fix is
OK. If it solves your problem it's a step in the right direction :). Should
any problems remain (or arise from this fix) we will notice.

Regards,
Peter Nevermann 

> -----Original Message-----
> From: Unico Hommes [mailto:Unico@hippo.nl]
> Sent: Wednesday, January 15, 2003 12:48
> To: Slide Developers Mailing List
> Subject: Loading parameters in EmbeddedDomain
> 
> 
> 
> Hi,
> 
> I noticed that when Slide was running in integrated mode with 
> Catalina, i.e. when Slide is started from within the catalina 
> wrapper classes, no parameters from Domain.xml were being 
> loaded and so no versioning was working in that scenario. I 
> traced the reason for this to be the fact that 
> wrappers.catalina.SlideServlerListener starts Slide using 
> EmbeddedDomain which has no means of loading parameters into 
> the Domain.
> 
> I fixed the problem by adding the following package private 
> method to Domain:
> 
> static void setParameters( Hashtable parameters ) {
> 	Domain.parameters = parameters;
> }
> 
> the following public method to EmbeddedDomain:
> 
> public void setParameters( Hashtable parameters ) {
> 	Domain.setParameters( parameters );
> }
> 
> and finally added the following code to 
> SlideServerListener::initializeDomain:
> 
>         // Loading domain parameters
>         Enumeration parametersEnum =
>             slideConfiguration.getConfigurations("parameter");
>         Hashtable parameters = new Hashtable();
>         while( parametersEnum.hasMoreElements() ) {
>             Configuration p = 
> (Configuration)parametersEnum.nextElement();
>             parameters.put( p.getAttribute("name"), p.getValue() );
>         }
>         domain.setParamters( parameters );
> 
> As I am not aware of all the design issues involved perhaps 
> someone could review these changes and comment on them. If 
> there are no problems with this approach I could prepare a 
> patch if you like.
> 
> Regards,
> 
> Unico Hommes
> 
> 
> 
> --
> To unsubscribe, e-mail:   
<mailto:slide-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:slide-dev-help@jakarta.apache.org>

--
To unsubscribe, e-mail:   <mailto:slide-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:slide-dev-help@jakarta.apache.org>

[prev in list] [next in list] [prev in thread] [next in thread]