[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sleuthkit-developers
Subject:    [sleuthkit-developers] [ sleuthkit-Bugs-3441763 ] Error in verbose output
From:       SourceForge.net <noreply () sourceforge ! net>
Date:       2013-01-29 22:12:50
Message-ID: E1U0JQC-0004Os-A7 () sfs-ml-1 ! v29 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Bugs item #3441763, was opened at 2011-11-24 03:56
Message generated for change (Comment added) made by carrier
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=477889&aid=3441763&group_id=55685

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Joachim Metz (jbmetz)
Assigned to: Nobody/Anonymous (nobody)
Summary: Error in verbose output

Initial Comment:
tsk3/fs/iso9660.c:2329

    if (tsk_verbose) {
        tsk_fprintf(stderr, "iso9660_open img_info: %lu"
            " ftype: %" PRIu8 " test: %" PRIu8 "\n", (uintptr_t) img_info,
            ftype, test);
    }

The %lu in this code should be %jd on Linux. Otherwise it prints an incorrect value on a 64-bit platform.


----------------------------------------------------------------------

>Comment By: Brian Carrier (carrier)
Date: 2013-01-29 14:12

Message:
[master 9d70763] Fixed some debug messages in iso9660 of memory pointers
that coudl be too big for data type in printf -- issue 3441763
 1 file changed, 20 insertions(+), 22 deletions(-)

A combination of removing some of the statements and changing them to
PRIu64 with needed casts. That seemed to be the safest cross platform
approach.

----------------------------------------------------------------------

Comment By: Joachim Metz (jbmetz)
Date: 2011-11-24 05:09

Message:
sk3/fs/ntfs_dent.c:1001

            rec_len =
                (uint32_t) (idxalloc_len - (uintptr_t) idxrec_p -
                (uintptr_t) idxalloc);

            if (tsk_verbose)
                tsk_fprintf(stderr,
                    "ntfs_dir_open_meta: Processing final index record
(len: %"
                    PRIu32 ")\n", rec_len);

calculation of rec_len seems to return a negative value

----------------------------------------------------------------------

Comment By: Joachim Metz (jbmetz)
Date: 2011-11-24 05:04

Message:
tsk3/fs/ntfs_dent.c:456

                "ntfs_proc_idxentry: Entry Details of %s: Str Len: %"
                PRIu16 "  Len to end after current: %" PRIu64
                "  flags: %x\n", fs_name->name, tsk_getu16(fs->endian,
                    a_idxe->strlen),
                (uint64_t) (endaddr_alloc - (uintptr_t) a_idxe -
                    tsk_getu16(fs->endian, a_idxe->idxlen)),
                fs_name->flags);

Please check the  %" PRIu64 " value calculation it seems to turn negative
on a 64-bit platform.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=477889&aid=3441763&group_id=55685

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
sleuthkit-developers mailing list
sleuthkit-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sleuthkit-developers
[prev in list] [next in list] [prev in thread] [next in thread]