[prev in list] [next in list] [prev in thread] [next in thread] 

List:       silc-devel
Subject:    Gaim-silc (0.82.1) and Public Key Authentication
From:       Michele Baldessari <michele () pupazzo ! org>
Date:       2004-09-06 10:49:19
Message-ID: 1094467759.32522.5.camel () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi,

public key authentication if your key is password protected doesn't work
since if there's a password set in the options, SILC_AUTH_PASSWORD is
always preferred.=20

Attached a quick fix (only briefly tested) which gives precedence to
SILC_AUTH_PUBLIC_KEY if the respective flag in options is set.

Ciao,
Michele


["silc-gaim-pubkey-with-password.diff" (silc-gaim-pubkey-with-password.diff)]

--- ops.c.orig	2004-09-06 12:00:45.191612488 +0200
+++ ops.c	2004-09-06 11:32:02.575489944 +0200
@@ -1600,6 +1600,12 @@
 		gaim_connection_update_progress(gc, _("Resuming session"), 4, 5);
 	else
 		gaim_connection_update_progress(gc, _("Authenticating connection"), 4, 5);
+	
+	
+	if (gaim_account_get_bool(sg->account, "pubkey-auth", FALSE)) {
+		completion(TRUE, SILC_AUTH_PUBLIC_KEY, NULL, 0, context);
+		return;
+	}
 
 	/* Check configuration if we have this connection configured.  If we
 	   have then return that data immediately, as it's faster way. */
@@ -1608,10 +1614,6 @@
 			   strlen(gc->account->password), context);
 		return;
 	}
-	if (gaim_account_get_bool(sg->account, "pubkey-auth", FALSE)) {
-		completion(TRUE, SILC_AUTH_PUBLIC_KEY, NULL, 0, context);
-		return;
-	}
 
 	/* Resolve the authentication method from server, as we may not know it. */
 	internal = silc_calloc(1, sizeof(*internal));

["signature.asc" (application/pgp-signature)]

_______________________________________________________________________
Info:    https://lists.silcnet.org/mailman/listinfo/silc-announce
Archive: https://lists.silcnet.org/pipermail/silc-announce
FAQ:     http://silcnet.org/support/faq/

[prev in list] [next in list] [prev in thread] [next in thread]