[prev in list] [next in list] [prev in thread] [next in thread] 

List:       shibboleth-dev
Subject:    Patch Request for idp-parent
From:       Dan McLaughlin via dev <dev () shibboleth ! net>
Date:       2022-05-28 10:10:19
Message-ID: CANi0WjXycebovL1-Zij-QMXJaHO1H+2NDUrLiYHokt6xE-GNvA () mail ! gmail ! com
[Download RAW message or body]

Hey Scott,

Would you please consider this patch for the 4.2.2 release? Adding
attachClasses to the maven-war-plugin will attach a jar to the build
artifacts for all war modules. This will provide an easy mechanism for
downstream projects to use the <type>jar</type> or
<classifier>classes</classifier> so Maven dependencyManagement can be
used to override war dependencies if necessary. For example, if a
critical bug is found in a third-party dependency embedded in the IdP
war, and waiting for the next release is not feasible. Without this
option, downstream projects must use overlay excludes and manually add
dependencies to their projects, which can become cumbersome to manage.
Thanks for your consideration!

By the way, I would have opened a ticket on this, but neither of my
accounts had access to submit a request.

Index: idp-parent/pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/idp-parent/pom.xml b/idp-parent/pom.xml
--- a/idp-parent/pom.xml (revision de71f27193334f22c4f4618b3f2166b0e85a3b6b)
+++ b/idp-parent/pom.xml (date 1653732202811)
@@ -110,7 +110,7 @@
             <groupId>org.testng</groupId>
             <artifactId>testng</artifactId>
             <scope>test</scope>
-        </dependency>
+        </dependency>
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
@@ -206,6 +206,20 @@
                 </configuration>
             </plugin>

+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-war-plugin</artifactId>
+            <configuration>
+              <!--
+              Adding attachClasses to the maven-war-plugin will
attach a jar to the
+              build artifacts for all war modules. This will provide
an easy mechanism for
+              downstream projects to use the <type>jar</type> or
<classifier>classes</classifier>
+              so Maven dependencyManagement can be used to override
war dependencies if necessary.
+              -->
+              <attachClasses>true</attachClasses>
+            </configuration>
+          </plugin>
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>




--

Thanks,

Dan McLaughlin
Technology Consortium, LLC
dmclaughlin@tech-consortium.com
mobile: 512.633.8086
http://www.tech-consortium.com

NOTICE: This e-mail message and all attachments transmitted with it
are for the sole use of the intended recipient(s) and may contain
confidential and privileged information. Any unauthorized review, use,
disclosure, or distribution is strictly prohibited. The contents of
this e-mail are confidential and may be subject to work product
privileges. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.

["idp-parent.patch" (application/x-patch)]

Index: idp-parent/pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/idp-parent/pom.xml b/idp-parent/pom.xml
--- a/idp-parent/pom.xml	(revision de71f27193334f22c4f4618b3f2166b0e85a3b6b)
+++ b/idp-parent/pom.xml	(date 1653732202811)
@@ -110,7 +110,7 @@
             <groupId>org.testng</groupId>
             <artifactId>testng</artifactId>
             <scope>test</scope>
-        </dependency>        
+        </dependency>
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
@@ -206,6 +206,20 @@
                 </configuration>
             </plugin>
 
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-war-plugin</artifactId>
+            <configuration>
+              <!--
+              Adding attachClasses to the maven-war-plugin will attach a jar to the
+              build artifacts for all war modules. This will provide an easy mechanism for
+              downstream projects to use the <type>jar</type> or <classifier>classes</classifier>
+              so Maven dependencyManagement can be used to override war dependencies if necessary.
+              -->
+              <attachClasses>true</attachClasses>
+            </configuration>
+          </plugin>
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>


-- 
To unsubscribe from this list send an email to dev-unsubscribe@shibboleth.net


[prev in list] [next in list] [prev in thread] [next in thread]