[prev in list] [next in list] [prev in thread] [next in thread] 

List:       shibboleth-dev
Subject:    RE: [java-identity-provider COMMIT] in /trunk: idp-authn-api/pom.xml idp-authn-api/src/main/java/net
From:       "Rod Widdowson" <rdw () steadingsoftware ! com>
Date:       2016-09-21 9:49:17
Message-ID: 00b201d213ed$6b94b390$42be1ab0$ () steadingsoftware ! com
[Download RAW message or body]

> This commit is some code I can easily roll back that demonstrates the work to \
> instrument the password validators with success and
failure
> counters. It includes some of the features we talked about Friday:
> 
> - the instrumented code calls a method we implement to obtain the Counter, not a \
>                 Metrics API directly
> - the code I supplied returns either a real Counter or a DisabledCounter \
>                 conditionally based on logging category
> - the metric is reported only if the logging category allows it
> - the logging category can change at runtime, turning the metric on and off

FWIW  I'd say that this hangs together pretty well and you and Tom addressed the only \
question I had.  I like what it's doing and I'd say the disruption is pretty minimal.

/R

-- 
To unsubscribe from this list send an email to dev-unsubscribe@shibboleth.net


[prev in list] [next in list] [prev in thread] [next in thread]