[prev in list] [next in list] [prev in thread] [next in thread] 

List:       selinux
Subject:    libsepol bug report
From:       David Binderman <dcb314 () hotmail ! com>
Date:       2015-11-24 19:11:17
Message-ID: DUB128-W116CD2BD4AFE8BA94BEB989C060 () phx ! gbl
[Download RAW message or body]

Hello there,

./cil/src/cil_tree.c:1279:36: warning: duplicated 'if' condition [-Wduplicated-cond]

Source code is

            if (filecon->context_str != NULL) {
                cil_log(CIL_INFO, " %s", filecon->context_str);
            } else if (filecon->context != NULL) {
                cil_tree_print_context(filecon->context);
            } else if (filecon->context_str != NULL) {
                cil_log(CIL_INFO, " %s", filecon->context_str);
            }

Two mentions of filecon->context_str. Suggest code rework.

Regards

David Binderman

 		 	   		  
_______________________________________________
Selinux mailing list
Selinux@tycho.nsa.gov
To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov.
[prev in list] [next in list] [prev in thread] [next in thread]