[prev in list] [next in list] [prev in thread] [next in thread] 

List:       selinux
Subject:    Re: Illegal errno from kernel
From:       Stephen Smalley <sds () tycho ! nsa ! gov>
Date:       2007-08-14 18:11:43
Message-ID: 1187115103.26008.246.camel () moss-spartans ! epoch ! ncsc ! mil
[Download RAW message or body]

On Tue, 2007-08-14 at 13:55 -0400, Stephen Smalley wrote:
> On Tue, 2007-08-14 at 10:51 -0700, Steve G wrote:
> > Hi,
> > 
> > In security/selinux/ss/services.c at the selinux_audit_rule_init() function is
> > this code:
> > 
> >         if (!ss_initialized)
> >                 return -ENOTSUPP;
> > 
> > The audit system sends that to user space, but its a special value that is
> > supposed to be internal to the kernel. Should the audit system look for this
> > value and change it when it calls the function, or should we change this value in
> > the selinux code? And if we change it, what should it be? EINVAL doesn't make
> > sense as the syntax of what's being asked to do is correct. Should we define
> > something like ENOMAC?
> 
> It should likely have been -EOPNOTSUPP in the first place.  So I'd just
> change it to that.

...and we already use that elsewhere in the SELinux code.

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
[prev in list] [next in list] [prev in thread] [next in thread]