[prev in list] [next in list] [prev in thread] [next in thread] 

List:       seandroid-list
Subject:    Re: clean up in android.c
From:       William Roberts <bill.c.roberts () gmail ! com>
Date:       2012-09-21 18:21:17
Message-ID: CAFftDdpNrg_=b-Qu3isSx_+OYtmc993p+t3m=h8Q4ge6zWeyDQ () mail ! gmail ! com
[Download RAW message or body]

My only suggestion, and this boils down to having drastically different C
style would be to typedef your enum as follows:
typedef enum seapp_kind seapp_kind;

Then you can drop the enum prefix on functions. Again this is a style
thing, it looks good to me, although I did not compile or test it. I like
the mapping to drop the MLS count.

Bill

On Fri, Sep 21, 2012 at 7:38 AM, Stephen Smalley <sds@tycho.nsa.gov> wrote:

> On Thu, 2012-09-20 at 16:19 -0400, James Carter wrote:
> > > Attached is a patch that maps the lower 16 bits of the UID to a pair of
> > > categories. With this patch, only 512 categories are needed for the
> > > policy.
> > >
> > >
> >
> > Update to fix a few things that Steve noticed.
>
> Attached is a slightly revised version of the patch I intend to upload.
> It also rolls in a few other fixes based on previous comments from AOSP
> review.
>
>
>
> --
> Stephen Smalley
> National Security Agency
>



-- 
Respectfully,

William C Roberts

[Attachment #3 (text/html)]

My only suggestion, and this boils down to having drastically different C style would \
be to typedef your enum as follows:<div>typedef enum seapp_kind \
seapp_kind;</div><div><br></div><div>Then you can drop the enum prefix on functions. \
Again this is a style thing, it looks good to me, although I did not compile or test \
it. I like the mapping to drop the MLS count.</div> \
<div><br></div><div>Bill<br><br><div class="gmail_quote">On Fri, Sep 21, 2012 at 7:38 \
AM, Stephen Smalley <span dir="ltr">&lt;<a href="mailto:sds@tycho.nsa.gov" \
target="_blank">sds@tycho.nsa.gov</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div class="im">On Thu, 2012-09-20 at 16:19 -0400, James \
Carter wrote:<br> &gt; &gt; Attached is a patch that maps the lower 16 bits of the \
UID to a pair of<br> &gt; &gt; categories. With this patch, only 512 categories are \
needed for the<br> &gt; &gt; policy.<br>
&gt; &gt;<br>
&gt; &gt;<br>
&gt;<br>
&gt; Update to fix a few things that Steve noticed.<br>
<br>
</div>Attached is a slightly revised version of the patch I intend to upload.<br>
It also rolls in a few other fixes based on previous comments from AOSP<br>
review.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
--<br>
Stephen Smalley<br>
National Security Agency<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- \
<br>Respectfully,<br><br>William C Roberts<br><br><br> </div>


--
This message was distributed to subscribers of the seandroid-list mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe seandroid-list" without quotes as the message.


[prev in list] [next in list] [prev in thread] [next in thread]