[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sbcl-devel
Subject:    Re: [Sbcl-devel] PATCH: use the recently introduced
From:       "Attila Lendvai" <attila.lendvai () gmail ! com>
Date:       2008-07-21 13:33:04
Message-ID: b54b34af0807210633r7167324cp774041f1a4f10a1c () mail ! gmail ! com
[Download RAW message or body]

> it may be subjective, but i find it confusing that the package name is
> not prefixed for such symbols  printed in various errors and/or
> warnings that are available in the current package.
>
> this patch makes sure that fully qualified symbol names are printed at
> the following places: redefining in DEFUN, DEFMACRO, DEFCLASS and
> "slot names with the same SYMBOL-NAME but different SYMBOL-PACKAGE
> (possible package problem)".

any words on this?

i've updated the patch to apply cleanly to HEAD. i'm running sbcl with
this modification for a long time now, and i find it quite useful that
i get fully qualified symbol names, especially in the slots with same
symbol-name warning...

-- 
 attila

["print-symbol-with-prefix-uses.diff" (text/x-patch)]

Mon Jul 21 15:30:51 CEST 2008  attila.lendvai@gmail.com
  * Use sb-impl::print-symbol-with-prefix at a few places where it's useful to see \
                fully qualified symbol names
diff -rN old-sbcl/src/code/class.lisp new-sbcl/src/code/class.lisp
768c768,769
<              (warn "Redefining DEFTYPE type to be a class: ~S" name)
---
> (warn "redefining DEFTYPE type to be a class: ~
> ~/sb-impl::print-symbol-with-prefix/" name)
diff -rN old-sbcl/src/code/condition.lisp new-sbcl/src/code/condition.lisp
1307c1307
<              (format stream "redefining ~S in DEFUN"
---
> (format stream "redefining ~/sb-impl::print-symbol-with-prefix/ in DEFUN"
diff -rN old-sbcl/src/code/defmacro.lisp new-sbcl/src/code/defmacro.lisp
92c92,93
<                     (style-warn "redefining ~S in DEFMACRO" name))
---
> (style-warn "redefining ~/sb-impl::print-symbol-with-prefix/ ~
> in DEFMACRO" name))
diff -rN old-sbcl/src/code/defstruct.lisp new-sbcl/src/code/defstruct.lisp
720c720,721
<       ;;x  (style-warn "redefining ~S in DEFSTRUCT" accessor-name)))
---
> ;;x  (style-warn "redefining ~/sb-impl::print-symbol-with-prefix/ ~
> ;;                in DEFSTRUCT" accessor-name)))
diff -rN old-sbcl/src/pcl/std-class.lisp new-sbcl/src/pcl/std-class.lisp
910c910
<                   for class ~S:~4I~@:_~<~@{~S~^~:@_~}~:>~@:>"
---
> for class ~S:~4I~@:_~<~@{~/sb-impl::print-symbol-with-prefix/~^~:@_~}~:>~@:>"



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

_______________________________________________
Sbcl-devel mailing list
Sbcl-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-devel


[prev in list] [next in list] [prev in thread] [next in thread]