[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sbcl-commits
Subject:    [Sbcl-commits] master: Remove SB-SYS:GET-PAGE-SIZE
From:       Douglas Katzman via Sbcl-commits <sbcl-commits () lists ! sourceforge ! net>
Date:       2020-09-28 22:02:17
Message-ID: 1601330538.137480.5015 () sfp-scm-3 ! v30 ! lw ! sourceforge ! com
[Download RAW message or body]

The branch "master" has been updated in SBCL:
       via  12f6478ce9062f340282ccde350e03d78c64c0ae (commit)
      from  b1fb7ba7dc45a958661e599a0f7848ccdbea3144 (commit)

- Log -----------------------------------------------------------------
commit 12f6478ce9062f340282ccde350e03d78c64c0ae
Author: Douglas Katzman <dougk@google.com>
Date:   Mon Sep 28 17:58:15 2020 -0400

    Remove SB-SYS:GET-PAGE-SIZE
    
    Too conflictingly named to be kept around for anything. No need for it.
---
 contrib/sb-sprof/report.lisp | 2 +-
 package-data-list.lisp-expr  | 2 +-
 src/code/room.lisp           | 9 +--------
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/contrib/sb-sprof/report.lisp b/contrib/sb-sprof/report.lisp
index 25c7c5349..a6203b3c2 100644
--- a/contrib/sb-sprof/report.lisp
+++ b/contrib/sb-sprof/report.lisp
@@ -7,7 +7,7 @@
 
 (defconstant +alloc-region-size+
   #-gencgc
-  (get-page-size)
+  sb-c:+backend-page-bytes+
   #+gencgc
   (max sb-vm:gencgc-alloc-granularity sb-vm:gencgc-card-bytes))
 
diff --git a/package-data-list.lisp-expr b/package-data-list.lisp-expr
index 3a5f32ac5..12add2c49 100644
--- a/package-data-list.lisp-expr
+++ b/package-data-list.lisp-expr
@@ -2805,7 +2805,7 @@ SB-KERNEL) have been undone, but probably more remain."
                "FOREIGN-SYMBOL-SAP"
                "FOREIGN-SYMBOL-ADDRESS"
                "FOREIGN-SYMBOL-DATAREF-SAP"
-               "GET-MACHINE-VERSION" "GET-PAGE-SIZE" "GET-SYSTEM-INFO"
+               "GET-MACHINE-VERSION" "GET-SYSTEM-INFO"
                "IN-INTERRUPTION"
                "INTERACTIVE-INTERRUPT"
                "INT-SAP"
diff --git a/src/code/room.lisp b/src/code/room.lisp
index fe0442534..7b7a7b0a3 100644
--- a/src/code/room.lisp
+++ b/src/code/room.lisp
@@ -11,8 +11,6 @@
 
 (in-package "SB-VM")
 
-(eval-when (:compile-toplevel :load-toplevel :execute)
-  (export 'sb-sys::get-page-size "SB-SYS"))
 
 ;;;; type format database
 
@@ -847,11 +845,6 @@ We could try a few things to mitigate this:
 
 ;;;; PRINT-ALLOCATED-OBJECTS
 
-;;; This notion of page-size is completely arbitrary - it affects 2 things:
-;;; (1) how much output to print "per page" in print-allocated-objects
-;;; (2) sb-sprof deciding how many regions [sic] were made if #+cheneygc
-(defun get-page-size () sb-c:+backend-page-bytes+)
-
 ;;; This function is sheer madness.  You're better off using
 ;;; LIST-ALLOCATED-OBJECTS and then iterating over that, to avoid
 ;;; seeing all the junk created while doing this thing.
@@ -865,7 +858,7 @@ We could try a few things to mitigate this:
     (let* ((space-start (ash start n-fixnum-tag-bits))
            (space-end (ash end n-fixnum-tag-bits))
            (space-size (- space-end space-start))
-           (pagesize (get-page-size))
+           (pagesize sb-c:+backend-page-bytes+)
            (start (+ space-start (round (* space-size percent) 100)))
            (printed-conses (make-hash-table :test 'eq))
            (pages-so-far 0)

-----------------------------------------------------------------------


hooks/post-receive
-- 
SBCL


_______________________________________________
Sbcl-commits mailing list
Sbcl-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-commits
[prev in list] [next in list] [prev in thread] [next in thread]