[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sbcl-commits
Subject:    [Sbcl-commits] master: Fix buglet caused by shadowed global variable.
From:       "Douglas Katzman" <snuglas () users ! sourceforge ! net>
Date:       2017-03-30 17:36:04
Message-ID: 1490895364.322476.20641 () sfp-scm-6 ! v30 ! ch3 ! sourceforge ! com
[Download RAW message or body]

The branch "master" has been updated in SBCL:
       via  84dac2498c0d94211e0e1cc767502926bec19d14 (commit)
      from  4fe75dde0def4bc37c8b94918a93f150cb500c20 (commit)

- Log -----------------------------------------------------------------
commit 84dac2498c0d94211e0e1cc767502926bec19d14
Author: Douglas Katzman <dougk@google.com>
Date:   Thu Mar 30 13:29:12 2017 -0400

    Fix buglet caused by shadowed global variable.
    
    The madvise() call at the last line of wipe_nonpinned_words() was rendered
    useless, but there was no damage otherwise, because we don't rely on the
    system call to actually zero out the bitmap of pins, as can be seen by the
    fact that the code is inside an #ifdef.
---
 src/runtime/gencgc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/runtime/gencgc.c b/src/runtime/gencgc.c
index a90e9f5..b7adcc1 100644
--- a/src/runtime/gencgc.c
+++ b/src/runtime/gencgc.c
@@ -4061,7 +4061,7 @@ gc_init(void)
     gc_init_immobile();
 #endif
 
-    size_t pins_map_size_in_bytes =
+    pins_map_size_in_bytes =
       (n_dwords_in_card / N_WORD_BITS) * sizeof (uword_t) * page_table_pages;
     /* We use mmap directly here so that we can use a minimum of
        system calls per page during GC.

-----------------------------------------------------------------------


hooks/post-receive
-- 
SBCL

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Sbcl-commits mailing list
Sbcl-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-commits
[prev in list] [next in list] [prev in thread] [next in thread]