[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sbcl-commits
Subject:    [Sbcl-commits] master: Comment some stuff.
From:       "Douglas Katzman" <snuglas () users ! sourceforge ! net>
Date:       2015-12-31 2:59:19
Message-ID: E1aETSU-0000bY-In () sfs-ml-1 ! v29 ! ch3 ! sourceforge ! com
[Download RAW message or body]

The branch "master" has been updated in SBCL:
       via  ceaf5dfc5b00e5fe055265207e8f06dc7d12b3fc (commit)
      from  15b24ac286af6084929ab9dc45f077a2ab4850f4 (commit)

- Log -----------------------------------------------------------------
commit ceaf5dfc5b00e5fe055265207e8f06dc7d12b3fc
Author: Douglas Katzman <dougk@google.com>
Date:   Wed Dec 30 20:57:19 2015 -0500

    Comment some stuff.
---
 src/code/load.lisp   |    5 +++++
 src/code/stream.lisp |    4 ++++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/src/code/load.lisp b/src/code/load.lisp
index 09d4e46..f1ed4e6 100644
--- a/src/code/load.lisp
+++ b/src/code/load.lisp
@@ -79,6 +79,11 @@
 ;;; FIXME: why do all of these reading functions and macros declare
 ;;; (SPEED 0)?  was there some bug in the compiler which has since
 ;;; been fixed?  --njf, 2004-09-08
+;;; Afaict, the (SPEED 0) declarations in here avoid code bloat,
+;;; by counteracting the INLINE declaration on the local definition
+;;; of FAST-READ-BYTE. At least, that is the effect, and it seems
+;;; reasonable. Pretty much the INLINE declaration is probably
+;;; the thing that deserves to go away.
 
 ;;; Read a signed integer.
 (defmacro fast-read-s-integer (n)
diff --git a/src/code/stream.lisp b/src/code/stream.lisp
index 9337633..8b43680 100644
--- a/src/code/stream.lisp
+++ b/src/code/stream.lisp
@@ -460,6 +460,10 @@
   ;; that of a-s-read-char
   (declare (ignore recursive-p))
   (with-fast-read-byte (t stream eof-error-p eof-value)
+    ;; FIXME: the overhead of the UNWIND-PROTECT inserted by
+    ;; WITH-FAST-READ-BYTE significantly impacts the time taken
+    ;; by single byte reads. For this use-case we could
+    ;; probably just change it to a PROG1.
     (fast-read-byte)))
 
 (defun read-byte (stream &optional (eof-error-p t) eof-value)

-----------------------------------------------------------------------


hooks/post-receive
-- 
SBCL

------------------------------------------------------------------------------
_______________________________________________
Sbcl-commits mailing list
Sbcl-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-commits
[prev in list] [next in list] [prev in thread] [next in thread]