[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: [PATCHv2] cifs-utils: work around missing krb5_free_string in Heimdal
From:       Pavel Shilovsky via samba-technical <samba-technical () lists ! samba ! org>
Date:       2022-03-31 23:12:36
Message-ID: CAKywueRDRwg_eyVjFDfFZhxCwC00aAELMa432Z-PLHtWDtjkZA () mail ! gmail ! com
[Download RAW message or body]

Thanks for the patch! Merged.

--
Best regards,
Pavel Shilovsky

=D0=BF=D1=82, 4 =D0=BC=D0=B0=D1=80. 2022 =D0=B3. =D0=B2 14:58, Jeremy Allis=
on via samba-technical
<samba-technical@lists.samba.org>:
>
> On Sat, Mar 05, 2022 at 12:51:43AM +0200, atheik wrote:
> >On 3/4/22, Jeremy Allison <jra@samba.org> wrote:
> >> Does cifs-utils have a libreplace equivalent ?
> >
> >I have no idea about libreplace but cifs.upcall.c of
> >cifs-utils already has a lot of these #ifdefs for
> >compatibility between MIT and Heimdal KRB5.
> >
> >> Wouldn't it be easier to test for the existence of
> >> krb5_free_string() and write a libreplace wrapper
> >> function so krb5_free_string() can be called from
> >> all code without #ifdefs in the main code ?
> >
> >This patch adds just another #ifdef to cifs.upcall.c
> >so that cifs-utils builds against Heimdal again.
> >
> >I have attached a new patch that doesn't place the
> >#ifdefs in the function body.
>
> That looks cleaner to me, thanks !
>

[prev in list] [next in list] [prev in thread] [next in thread]