[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: [PATCH] Fix strict aliasing warnings in ctdb_client
From:       Amitay Isaacs via samba-technical <samba-technical () lists ! samba ! org>
Date:       2018-04-30 9:15:43
Message-ID: CAJ+X7mRZYdxJP3_pnRh=DEgtC+EZ=Yi3bWY0fJqJLFqeqMpR_w () mail ! gmail ! com
[Download RAW message or body]

On Mon, Apr 30, 2018 at 6:49 PM, Stefan Metzmacher <metze@samba.org> wrote:
> Am 30.04.2018 um 10:45 schrieb Amitay Isaacs via samba-technical:
>> On Sat, Apr 28, 2018 at 12:47 AM, Andreas Schneider via
>> samba-technical <samba-technical@lists.samba.org> wrote:
>>> Hi,
>>>
>>> see attached.
>>>
>>>
>>> Review much appreciated.
>>>
>>
>> This is actually wrong.  It fixes the data format to LE, which will
>> break things on BE machine.
>>
>> We need to fix the format for all the stored data and on-wire data.
>> It might be better to change all the formats at once since it will
>> break backward compatibility.
>
> The function is actually not used and can be removed instead ...

Sure.  I still wanted to point out what was wrong with the first patch.

I am preparing a patch which drops most of the unused functions from
ctdb_client.c.

Andreas, please file CTDB bugs against CTDB component rather than Clustering.

Amitay.

[prev in list] [next in list] [prev in thread] [next in thread]