[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: [PR PATCH] build:wafsamba: Set the default installation prefix for Waf 1.8
From:       "Thomas Nagy" <tnagy () waf ! io>
Date:       2015-09-29 16:53:37
Message-ID: E1Zgy9p-0006Dm-UO () rmm6prod02 ! runbox ! com
[Download RAW message or body]

On Tue, 29 Sep 2015 11:46:58 +0200, Michael Adam wrote:

> On 2015-09-28 at 20:41 +0200, Stefan Metzmacher wrote:
> > Am 28.09.2015 um 17:22 schrieb github@samba.org:
> > > There is a new pull request by ita1024 against master on the Samba Samba Github repository
> > > 
> > > https://github.com/ita1024/samba waf_default_prefix
> > > https://github.com/samba-team/samba/pull/15
> > > 
> > > build:wafsamba: Set the default installation prefix for Waf 1.8
> > > These changes enable the default installation prefix settings to
> > > take effect in both Waf 1.5 and 1.8 with no additional code changes.
> > > 
> > > A patch file from https://github.com/samba-team/samba/pull/15.patch is attached
> > 
> > If you add a Signed-off-by: line to the commit message,
> > you can add Reviewed-by: Stefan Metzmacher <metze@samba.org>.
> > 
> > Can we get a 2nd review?
> 
> pushed to autobuild after Thomas had update the PR

Thanks to both of you! I will not forget the Signed-off-by line next times.

Thomas



[prev in list] [next in list] [prev in thread] [next in thread]