[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: [PATCH] debug: make debug public again, for 4.3
From:       Brad Hards <bradh () frogmouth ! net>
Date:       2015-07-31 22:26:54
Message-ID: 2069144.sn2XQ1cSz0 () saxicola
[Download RAW message or body]

On Fri, 31 Jul 2015 10:09:08 PM you wrote:
> Hi!
Hi Volker, and thanks for looking at this.

> On Fri, Jul 31, 2015 at 05:49:52PM +1000, Brad Hards wrote:
> > This is to allow a staged migration for external clients (e.g.
> > openchange),
> > and does not represent a long term (including 4.4 and later) public API.
> 
> Why do we have to remove samba-debug as a separate
> dependency again? I thought the real problem is that
> samba-debug is not a public library?
So the change would be
 - private_library='True',
 +private_library='False',
?

That was my original suggestion, but (I think) jelmer suggested that there 
would / could be symbol conflict.

> I'm not sure we can do ABI guarantees like we do for
> libtalloc for example for samba-debug, but wouldn't it be
> sufficient to just make samba-debug a public and not a
> private library?
As long as we can link to it, no issue.

We might be adding samba-debug to some pkg-config file (unless the magic of 
wscript / waf does that for us) but that would be minor.

Brad




[prev in list] [next in list] [prev in thread] [next in thread]