[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: [PART4] [PATCHES] generate the param_table (FINALLY)
From:       Michael Adam <obnox () samba ! org>
Date:       2015-07-31 8:29:10
Message-ID: 20150731082910.GB4193 () samba ! org
[Download RAW message or body]


On 2015-07-31 at 19:56 +1200, Andrew Bartlett wrote:
> On Fri, 2015-07-31 at 09:32 +0200, Michael Adam wrote:
> > Hi Andrew,
> > 
> > Thanks for your comment!
> > 
> > On 2015-07-31 at 18:08 +1200, Andrew Bartlett wrote:
> > > On Wed, 2015-07-29 at 12:20 +0200, Michael Adam wrote:
> > > > Hi,
> > > > 
> > > > FYI: I have rebased the branch mentioned below.
> > > > The code still cleanly applies and builds...
> > > > 
> > > > :-)
> > > > 
> > > > Cheers - Michael
> > > 
> > > My only comment is regarding:
> > > 
> > > param: don't list '-valid' and 'copy' as synonyms - they aren't
> > >     
> > >     Signed-off-by: Michael Adam <obnox@samba.org>
> > > 
> > > Because in e629d390f5ab5d3d74c6e5267f17585916e50950 you renamed
> > > FLAG_HIDE to FLAG_SYNONYM, and both copy and -valid should be hidden. 
> > > 
> > > Have you confirmed -valid and copy are still hidden correctly?
> > 
> > Hiding does not exist any more: it was a concept in SWAT.
> > copy and -valid were examples where the rather automatic
> > renaming of FLAG_HIDE to FLAG_SYNONYM was not correct,
> > since these are not synonyms. This is fixed by this new change.
> 
> What about testparm and testparm -v?

With respect to valid and copy, the output is the identical.

There is some diff is where I changed (systematized) which
writing of an option is the default writing.

Plus one difference that 'comment = ' is not listed any more
now, but I don't yet see why. Will investigate.

Cheers - Michael

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]