[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: [PATCH] samba-tool ntacl do a proper VFS connect
From:       Jeremy Allison <jra () samba ! org>
Date:       2012-12-29 1:37:12
Message-ID: 20121229013712.GA24869 () jeremy-HP
[Download RAW message or body]

On Fri, Dec 28, 2012 at 04:35:00PM +1100, Andrew Bartlett wrote:
> On Fri, 2012-12-28 at 15:07 +1100, Andrew Bartlett wrote:
> > Attached for review is the small collection of patches I've been working
> > on over the holidays, now that I have written some tests for them.
> > 
> > Most of the substantive changes have been posted to one or other list,
> > or in bugzilla already, but what I hadn't asked for yet is specific
> > review (and optionally push). 
> > 
> > Here are the patches to have samba-tool ntacl do a proper VFS
> > connect to a specific share, which makes it give less warnings and uses
> > the VFS layer more correctly.
> > 
> > I know most folks are busy with family over this holiday time, but if I
> > could get some review on these changes, i would appreciate it.
> 
> On Simo's request, the attached revised patches try to clarify why the
> crate_conn_struct() function was split into create_conn_struct() and
> create_conn_struct_cwd().  
> 
> Simo, I would rather not make it create_conn_struct_nocwd() instead,
> because in the long term this is clearer, and it makes it clear in the
> callers that this code changes the current working directory (which
> seems to have surprised Jeremy, who wrote in the function header
> comment:
> 
> Note: this performs a vfs connect and CHANGES CWD !!!! JRA.

Actually it didn't surprise me -  I wrote that comment to
make sure that anyone else looking at it knew that it had
a BIG side effect.

> If we have to have two names (which we do), encoding this clearly in the
> name seems the most reasonable thing.

I'd like to look these patches over very carefully, but
I won't be back in at work fulltime until Jan 3rd (Thursday).

Sorry for the delay, family vacation has to come first :-).

Jeremy.
[prev in list] [next in list] [prev in thread] [next in thread]