[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: [PATCH] s4-srvsvc: Do not return hidden shares in
From:       Andrew Bartlett <abartlet () samba ! org>
Date:       2010-12-17 6:11:00
Message-ID: 1292566260.22579.39.camel () obed
[Download RAW message or body]

On Tue, 2010-12-07 at 15:03 -0500, brendan powers wrote:
> Hello, I am trying to solve a problem where samba4 did not seem to
> honor the browsable = no option. I've tracked it down to the
> dcesrv_srvsvc_NetShareEnumAll function. This function does not check
> if a share is hidden before returning it. The
> dcesrv_srvsvc_NetShareEnum function does though. In the provided
> patch, I've modified dcesrv_srvsvc_NetShareEnumAll to not return
> hidden shares. However, I'm not sure this is the right approach. Can
> someone who is familiar with this part of the code look it over?

Tridge and I looked at it, and the only concern he had was to ensure
that the different types of hidden shares were dealt with correctly.  

That is, should we hide these totally, or just mark them as 'hidden'?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

[prev in list] [next in list] [prev in thread] [next in thread]