[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: [SCM] Samba Shared Repository - branch master updated
From:       tridge () samba ! org
Date:       2010-11-30 2:25:04
Message-ID: 19700.24704.23071.817554 () samba ! org
[Download RAW message or body]

Hi Jelmer,

 > pass is a noop in Python, so checking the value of enum doesn't change
 > the behaviour of this code in any way. If there's no need to handle this
 > error, perhaps we can just get rid of this try/except completely?

I think we do need to handle this, although its obviously not in our
testsuite. I'll push a fix.

Thanks for spotting this!

Cheers, Tridge
[prev in list] [next in list] [prev in thread] [next in thread]