[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: Patch to fix a segfault while duping some security descriptors
From:       Matthias_Dieter_Wallnöfer <mdw () samba ! org>
Date:       2010-06-18 16:44:25
Message-ID: 4C1BA269.3030609 () samba ! org
[Download RAW message or body]

Nadia,

do we still need this patch? Would you like to push it? Or how to 
proceed here?

Matthias

Nadezhda Ivanova wrote:
> Hi,
> That's a nice fix, but where is the caller that provided an uninitialized
> DACL? Maybe that needs fixing too.
>
>
> On Wed, May 26, 2010 at 12:49 AM, Anatoliy Atanasov<
> anatoliy.atanasov@postpath.com>  wrote:
>
>    
>> Hi there,
>>
>> I had the same problem :), just waiting for the patch to be approved before
>> pushing it.
>>
>> Thanks,
>> Anatoliy
>> ----- Original Message -----
>>      
>>> From: samba-technical-bounces@lists.samba.org<
>>>        
>> samba-technical-bounces@lists.samba.org>
>>      
>>> To: samba-technical@lists.samba.org<samba-technical@lists.samba.org>
>>> Sent: Wednesday, May 26, 2010 0:04:47 AM (GMT+02:00) Athens, Bucharest,
>>>        
>> Istanbul
>>      
>>> Subject: Patch to fix a segfault while duping some security descriptors
>>>        
>>      
>>>> I found a segfault when duplicating a security descriptor that was
>>>>          
>>> missing sacls or dacls. I ran into this when a piece of my code wrote
>>> a security descriptor for an LDAP user that had no sacls. After doing
>>> that, checking or unchecking the "User cannot change password" option
>>> in the AD admin tool would cause samba to crash.
>>>
>>> I fixed this by checking if the acl was null in security_acl_dup
>>> function, and returning NULL if that was the case.
>>>        
>>      
>    

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic