--0016e6d58b282693c7048770ec3b Content-Type: text/plain; charset=ISO-8859-1 I found a segfault when duplicating a security descriptor that was missing sacls or dacls. I ran into this when a piece of my code wrote a security descriptor for an LDAP user that had no sacls. After doing that, checking or unchecking the "User cannot change password" option in the AD admin tool would cause samba to crash. I fixed this by checking if the acl was null in security_acl_dup function, and returning NULL if that was the case. --0016e6d58b282693c7048770ec3b Content-Type: text/x-patch; charset=US-ASCII; name="0001-libcli-Fixed-a-segfault-in-security_acl_dup-when-th.patch" Content-Disposition: attachment; filename="0001-libcli-Fixed-a-segfault-in-security_acl_dup-when-th.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g9n631250 RnJvbSA1NDMwN2ZjOWNkYjQ2MzNjMGNiNWEzOTdmMWRiMzliMDZkZTE0Y2Q1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmVuZGFuIFBvd2VycyA8YnJlbmRhbjBwb3dlcnNAZ21haWwu Y29tPgpEYXRlOiBUdWUsIDI1IE1heSAyMDEwIDE2OjE0OjM3IC0wNDAwClN1YmplY3Q6IFtQQVRD SF0gbGliY2xpOiBGaXhlZCBhIHNlZ2ZhdWx0IGluIHNlY3VyaXR5X2FjbF9kdXAgd2hlbiB0aGUg YWNsIGlzIE5VTEwuIFRoaXMgY2FuIGhhcHBlbiB3aGVuIGR1cGxpY2F0aW5nIGEgc2VjdXJpdHkg ZGVzY3JpcHRvciB0aGF0IGlzIG1pc3NpbmcgZWl0aGVyIHNhY2xzIG9yIGRhY2xzLgoKLS0tCiBs aWJjbGkvc2VjdXJpdHkvc2VjdXJpdHlfZGVzY3JpcHRvci5jIHwgICAgMiArKwogMSBmaWxlcyBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGli Y2xpL3NlY3VyaXR5L3NlY3VyaXR5X2Rlc2NyaXB0b3IuYyBiL2xpYmNsaS9zZWN1cml0eS9zZWN1 cml0eV9kZXNjcmlwdG9yLmMKaW5kZXggYjc3YTI4MS4uMDMxZjAyZSAxMDA2NDQKLS0tIGEvbGli Y2xpL3NlY3VyaXR5L3NlY3VyaXR5X2Rlc2NyaXB0b3IuYworKysgYi9saWJjbGkvc2VjdXJpdHkv c2VjdXJpdHlfZGVzY3JpcHRvci5jCkBAIC01NSw2ICs1NSw4IEBAIHN0cnVjdCBzZWN1cml0eV9h Y2wgKnNlY3VyaXR5X2FjbF9kdXAoVEFMTE9DX0NUWCAqbWVtX2N0eCwKIHsKIAlzdHJ1Y3Qgc2Vj dXJpdHlfYWNsICpuYWNsOwogCisJaWYob2FjbCA9PSBOVUxMKSByZXR1cm4oTlVMTCk7CisKIAlu YWNsID0gdGFsbG9jIChtZW1fY3R4LCBzdHJ1Y3Qgc2VjdXJpdHlfYWNsKTsKIAlpZiAobmFjbCA9 PSBOVUxMKSB7CiAJCXJldHVybiBOVUxMOwotLSAKMS41LjQuMwoK --0016e6d58b282693c7048770ec3b--