[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: svn commit: samba r15358 - in
From:       Jelmer Vernooij <jelmer () samba ! org>
Date:       2006-04-30 20:01:21
Message-ID: 1146427281.10686.4.camel () localhost ! localdomain
[Download RAW message or body]


Hi Metze,

On Sun, 2006-04-30 at 16:18 +0200, Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> shouldn't this be BOOL, I think we should just use BOOL OR bool
> consistent in the whole tree.
Agreed.

> 
> > +		if (!asn1_read_BOOLEAN(data, &critical)) {
> >  			return False;
> >  		}
> > +		critical = ctrl->critical;
> 
> this should be

Thanks, I've fixed it.

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer@samba.org> - http://samba.org/~jelmer/

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]