[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-technical
Subject:    Re: Announcing Samba 4.0.0TP1
From:       James Peach <jpeach () sgi ! com>
Date:       2006-01-30 4:42:36
Message-ID: 200601301542.36976.jpeach () sgi ! com
[Download RAW message or body]

On Sun, 29 Jan 2006 09:45 am, James Peach wrote:
> On 1/27/06, Stefan (metze) Metzmacher <metze@samba.org> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Jelmer Vernooij schrieb:
> > > Hi Ken,
> > >
> > > On Thu, Jan 26, 2006 at 02:50:20PM -0800, Ken Stone wrote about 'Re: Announcing Samba 4.0.0TP1':
> > >> I pulled down the 4.0.0TP1 bits yesterday just to take a look (ie not even
> > >> a glimmer of hope that I could get it to build :-).  What I found was that
> > >> I could not get beyond running configure ... It barfed all over the place.
> > >
> > >> Is there a plan to describe the toolset required to build 4.0 ?  I had
> > >> seen some stuff a while back about new compiler tech needed ?  What might
> > >> be nice is kind of a tookit guide so people like me can start looking
> > >> for what its going to take.
> > >
> > > Other then a shell, perl 5 and a c compiler, you shouldn't need
> > > anything. Can you post some of the error messages?
> >
> > The build on HP systems is known to be broken currently:
> > http://build.samba.org/?function=View+Build;host=gwen;tree=samba4;compiler=cc
> > http://build.samba.org/?function=View+Build;host=gwen;tree=samba4;compiler=gcc
> >
> > the error comes in with this commit and broke IRIX too:
> > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13071
> 
> Hmm ... that was me. Since I added that code specifically for IRIX,
> I'm very surprised it broke. I'm back in the office tomorrow, so I'll
> take a proper look and fix it.

Looks like the root cause here is that r13210 did not completely
revert r13208.  That is, torture/config.mk claims there is a file in
torture/rap/rap.c, but in fact it is still in torture/ipc/rap.c.

The attached patch fixes this for me, but I'll let you review and
commit it.

-- 
James Peach | jpeach@sgi.com | SGI Australian Software Group
I don't speak for SGI.


["torture-rap-build-fix.diff" (text/x-diff)]

Index: torture/config.mk
===================================================================
--- torture/config.mk	(revision 13224)
+++ torture/config.mk	(working copy)
@@ -124,7 +124,7 @@
 # Start SUBSYSTEM TORTURE_RAP
 [SUBSYSTEM::TORTURE_RAP]
 OBJ_FILES = \
-		rap/rap.o
+		ipc/rap.o
 REQUIRED_SUBSYSTEMS = \
 		LIBSMB
 # End SUBSYSTEM TORTURE_RAP


[prev in list] [next in list] [prev in thread] [next in thread]