[prev in list] [next in list] [prev in thread] [next in thread] 

List:       samba-cvs
Subject:    svn commit: samba r14834 - in trunk/source/rpcclient: .
From:       jra () samba ! org
Date:       2006-03-31 0:50:23
Message-ID: 20060331005023.18669162BDD () lists ! samba ! org
[Download RAW message or body]

Author: jra
Date: 2006-03-31 00:50:17 +0000 (Fri, 31 Mar 2006)
New Revision: 14834

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14834

Log:
Fix resource leak on error code path. Coverity #280.
Jeremy.

Modified:
   trunk/source/rpcclient/cmd_spoolss.c


Changeset:
Modified: trunk/source/rpcclient/cmd_spoolss.c
===================================================================
--- trunk/source/rpcclient/cmd_spoolss.c	2006-03-31 00:50:09 UTC (rev 14833)
+++ trunk/source/rpcclient/cmd_spoolss.c	2006-03-31 00:50:17 UTC (rev 14834)
@@ -2396,9 +2396,10 @@
 		curkey += strlen(subkey) + 1;
 	}
 
-	safe_free(keylist);
+done:
 
-done:
+	SAFE_FREE(keylist);
+
 	if (got_hnd)
 		rpccli_spoolss_close_printer(cli, mem_ctx, &hnd);
 

[prev in list] [next in list] [prev in thread] [next in thread]