[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rt-commit
Subject:    [Rt-commit] rt branch, 5.0/fix-width-md, created. rt-5.0.0-3-gb2a997a977
From:       sunnavy () bestpractical ! com (? sunnavy)
Date:       2020-07-29 14:05:48
Message-ID: 20200729140549.396E92418004 () booth ! bestpractical ! com
[Download RAW message or body]

The branch, 5.0/fix-width-md has been created
        at  b2a997a977e9b04dfcee12f07daa4bf105de3651 (commit)

- Log -----------------------------------------------------------------
commit f6f69d552e0fad14d6864d670f7eacabd55cb760
Author: sunnavy <sunnavy@bestpractical.com>
Date:   Wed Jul 29 01:48:51 2020 +0800

    Fix width/max-width for .width-md/.max-width-md
    
    They were wrongly set to the values belonging to *-lg

diff --git a/share/static/css/elevator-light/boxes.css \
b/share/static/css/elevator-light/boxes.css index d3e220e22f..d2d4f029f7 100644
--- a/share/static/css/elevator-light/boxes.css
+++ b/share/static/css/elevator-light/boxes.css
@@ -181,7 +181,7 @@ div.results .titlebox .titlebox-content {
 }
 
 .max-width-md {
-  max-width: 992px;
+  max-width: 768px;
 }
 
 .max-width-sm {
@@ -197,7 +197,7 @@ div.results .titlebox .titlebox-content {
 }
 
 .width-md {
-  width: 992px;
+  width: 768px;
 }
 
 .width-sm {

commit b2a997a977e9b04dfcee12f07daa4bf105de3651
Author: sunnavy <sunnavy@bestpractical.com>
Date:   Wed Jul 29 02:02:32 2020 +0800

    Switch to the correct *width-lg for existing *width-md elements
    
    Previously the width/max-width of .width-md/.max-width-md were wrongly
    set to 992px(the same as .width-lg/.max-width-lg), which has been fixed
    in f6f69d552e.
    
    We want to retain the UI, so here we switch to *width-lg.

diff --git a/share/html/Admin/CustomFields/Modify.html \
b/share/html/Admin/CustomFields/Modify.html index 4a23208fc3..fe3c2b36e0 100644
--- a/share/html/Admin/CustomFields/Modify.html
+++ b/share/html/Admin/CustomFields/Modify.html
@@ -237,7 +237,7 @@ jQuery( function() {
 </&>
 
 
-<&| /Widgets/TitleBox, title => 'Integration', class => \
'custom-field-info-integration', content_class => 'mx-auto width-md' &> +<&| \
/Widgets/TitleBox, title => 'Integration', class => 'custom-field-info-integration', \
content_class => 'mx-auto width-lg' &>  
 <div class="form-row">
   <div class="label col-2">
@@ -278,7 +278,7 @@ jQuery( function() {
 </&>
 
 % if ( $CustomFieldObj->Id && $CustomFieldObj->IsSelectionType && \
                !$CustomFieldObj->IsExternalValues ) {
-<&| /Widgets/TitleBox, title => 'Values', class => 'custom-field-info-values', \
content_class => 'mx-auto width-md' &> +<&| /Widgets/TitleBox, title => 'Values', \
class => 'custom-field-info-values', content_class => 'mx-auto width-lg' &>  <div \
class="form-row">  <div class="col-1"></div>
   <div class="edit_custom_field_values col-11">
@@ -298,7 +298,7 @@ jQuery( function() {
 
 % if ( $CustomFieldObj->Id && $CustomFieldObj->IsSelectionType && \
!$CustomFieldObj->IsExternalValues ) {  <div class="mx-auto max-width-lg">
-  <&| /Widgets/TitleBox, title => 'Add Values', class => \
'custom-field-info-add-values', content_class => 'mx-auto width-md' &> +  <&| \
/Widgets/TitleBox, title => 'Add Values', class => 'custom-field-info-add-values', \
content_class => 'mx-auto width-lg' &>  <div class="add_custom_field_value">
       <& /Admin/Elements/AddCustomFieldValue, CustomField => $CustomFieldObj &>
     </div>
diff --git a/share/html/Admin/Elements/ModifyTemplate \
b/share/html/Admin/Elements/ModifyTemplate index 58d6fda606..b3900e60c2 100644
--- a/share/html/Admin/Elements/ModifyTemplate
+++ b/share/html/Admin/Elements/ModifyTemplate
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<&| /Widgets/TitleBox, class => 'template-info-basics', content_class => 'mx-auto \
width-md' &> +<&| /Widgets/TitleBox, class => 'template-info-basics', content_class \
=> 'mx-auto width-lg' &>  <div class="form-row">
   <div class="label col-2">
     <&|/l&>Name</&>:
diff --git a/share/html/Admin/Lifecycles/Actions.html \
b/share/html/Admin/Lifecycles/Actions.html index 2a9d6434a1..80393eae94 100644
--- a/share/html/Admin/Lifecycles/Actions.html
+++ b/share/html/Admin/Lifecycles/Actions.html
@@ -59,7 +59,7 @@
   </div>
 </div>
 
-<form action="<%RT->Config->Get('WebPath')%>/Admin/Lifecycles/Actions.html" \
name="ModifyLifecycleRights" method="post" enctype="multipart/form-data" \
class="mx-auto max-width-md"> +<form \
action="<%RT->Config->Get('WebPath')%>/Admin/Lifecycles/Actions.html" \
name="ModifyLifecycleRights" method="post" enctype="multipart/form-data" \
class="mx-auto max-width-lg">  <input type="hidden" class="hidden" name="Name" \
value="<% $LifecycleObj->Name %>" />  <input type="hidden" class="hidden" name="Type" \
value="<% $LifecycleObj->Type %>" />  
diff --git a/share/html/Admin/Lifecycles/Rights.html \
b/share/html/Admin/Lifecycles/Rights.html index 22d856944f..93f75b1361 100644
--- a/share/html/Admin/Lifecycles/Rights.html
+++ b/share/html/Admin/Lifecycles/Rights.html
@@ -54,7 +54,7 @@
   </div>
 </div>
 
-<form action="<%RT->Config->Get('WebPath')%>/Admin/Lifecycles/Rights.html" \
name="ModifyLifecycleRights" method="post" enctype="multipart/form-data" \
class="mx-auto max-width-md"> +<form \
action="<%RT->Config->Get('WebPath')%>/Admin/Lifecycles/Rights.html" \
name="ModifyLifecycleRights" method="post" enctype="multipart/form-data" \
class="mx-auto max-width-lg">  <input type="hidden" class="hidden" name="Name" \
value="<% $LifecycleObj->Name %>" />  <input type="hidden" class="hidden" name="Type" \
value="<% $LifecycleObj->Type %>" />  

-----------------------------------------------------------------------
_______________________________________________
rt-commit mailing list
rt-commit@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit


[prev in list] [next in list] [prev in thread] [next in thread]