[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rsync
Subject:    [Bug 2389] block/character devices on Solaris yield wacky rsync
From:       samba-bugs () samba ! org
Date:       2005-02-27 23:19:11
Message-ID: 200502272319.j1RNJBeN011602 () dp3 ! samba ! org
[Download RAW message or body]

https://bugzilla.samba.org/show_bug.cgi?id=2389





------- Additional Comments From woodd@deshaw.com  2005-02-27 16:19 -------
Odd, my reply never made it through.  I'll paste my reply in "manually".  David

-----Original Message-----
From: Wood, David 
Sent: Friday, February 25, 2005 4:52 PM
To: 'samba-bugs@samba.org'
Subject: RE: [Bug 2389] block/character devices on Solaris yield wacky rsync stats


> Please let me know if this fixes the problem.

Hi Wayne,

The patch works just fine - thanks!  I had originally used the same patch;
however, I went with the stat wrapper because:

1) I thought including symlink (pipe, etc) sizes in statistics was intentional

2) I figured a purist would be upset if bogus data lingered in the stat structure

3) I'm not familiar enough with rsync internals to ensure that I would find all
possible "bad" uses of st_size.  You're certainly well versed in rsync internals
and can make such a determination ;-).

Anyway, much obliged for the fix.  David


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
-- 
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
[prev in list] [next in list] [prev in thread] [next in thread]