[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rrd-developers
Subject:    Re: [rrd-developers] Possible race conditions / data loss
From:       Sebastian Harl <sh () tokkee ! org>
Date:       2009-07-14 12:18:14
Message-ID: 20090714121814.GB31027 () chough ! tokkee ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi Kevin,

On Tue, Jul 14, 2009 at 07:01:38AM -0500, kevin brintnall wrote:
> > > Anyway, this should be easy to fix. See the patch, I'll send in a
> > > minute. Beware, though, that I do not have a RRDCacheD setup, so the
> > > patch is mostly untested - it compiles though ;-)
> > 
> > Your patch doesn't address the problem.  I will email another shortly.
> 
> I reviewed it again... your patch does address the problem nicely.

Thanks!

> I sent an updated one which removes the ci->flags mod (not necessary)

Yep, I know that it's currently unnecessary. However, imho, removing any
flags is better from a semantical point of view, since the object has
just been allocated and thus no flags apply yet. This _might_ avoid
problems in the future if free_cache_item() does care about some of the
flags in the future (which is not very unlikely imho).

> matches the if()-style up with the rest of the code.

Sure, go ahead :-)

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin


["signature.asc" (application/pgp-signature)]

_______________________________________________
rrd-developers mailing list
rrd-developers@lists.oetiker.ch
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers


[prev in list] [next in list] [prev in thread] [next in thread]