[prev in list] [next in list] [prev in thread] [next in thread]
List: rpmorg-maint
Subject: [Rpm-maint] =?utf-8?q?=5Brpm-software-management/rpm=5D_Try_tell?= =?utf-8?q?ing_cmake_that_the_proj
From: Panu Matilainen <notifications () github ! com>
Date: 2023-01-17 10:30:50
Message-ID: rpm-software-management/rpm/pull/2357 () github ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
…#2356)
Recently there have been a fair amount of random failures in the CI, due to apparent \
ordering errors / lack of dependencies that have been hard to reproduce locally. The \
key is probably CI running "make check" right away, which then proceeds on \
all the relevant targets in parallel. And nowhere at all we're telling it that \
the tests need the entire project to be already built. So apparently the "make \
install" in tests/populate often ends up building a significant part of the \
project and ... that two competing makes in the tree ever actually manage to complete \
at all is a small miracle.
Make populate_testing target depend on top-level cli utils to enforce at least \
"mostly sane" situation when running "make check" without a \
preceeding build. This should address the issue of random CI failures. You can view, \
comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2357
-- Commit Summary --
* Try telling cmake that the project needs to be built before testing (#2356)
-- File Changes --
M tests/CMakeLists.txt (6)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/2357.patch
https://github.com/rpm-software-management/rpm/pull/2357.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2357
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2357@github.com>
[Attachment #5 (text/html)]
<p dir="auto">…<a class="issue-link js-issue-link" data-error-text="Failed to load \
title" data-id="1535973052" data-permission-text="Title is private" \
data-url="https://github.com/rpm-software-management/rpm/issues/2356" \
data-hovercard-type="issue" \
data-hovercard-url="/rpm-software-management/rpm/issues/2356/hovercard" \
href="https://github.com/rpm-software-management/rpm/issues/2356">#2356</a>)</p> <p \
dir="auto">Recently there have been a fair amount of random failures in the CI, due \
to apparent ordering errors / lack of dependencies that have been hard to reproduce \
locally. The key is probably CI running "make check" right away, which then proceeds \
on all the relevant targets in parallel. And nowhere at all we're telling it that the \
tests need the entire project to be already built. So apparently the "make install" \
in tests/populate often ends up building a significant part of the project and ... \
that two competing makes in the tree ever actually manage to complete at all is a \
small miracle.</p> <p dir="auto">Make populate_testing target depend on top-level cli \
utils to enforce at least "mostly sane" situation when running "make check" without a \
preceeding build. This should address the issue of random CI failures.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/rpm-software-management/rpm/pull/2357'>https://github.com/rpm-software-management/rpm/pull/2357</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/rpm-software-management/rpm/pull/2357/commits/719a748d594dc0ea261a45266d7e6782968af951" \
class="commit-link">719a748</a> Try telling cmake that the project needs to be built \
before testing (#2356)</li> </ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: \
inline-block">(<a href="https://github.com/rpm-software-management/rpm/pull/2357/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/2357/files#diff-4461c \
617ceae0c7e0206622aacdf555aedd62eb129c2efb74c84fa1567bcbe0d">tests/CMakeLists.txt</a> \
(6) </li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/rpm-software-management/rpm/pull/2357.patch'>https://github.com/rpm-software-management/rpm/pull/2357.patch</a></li>
<li><a href='https://github.com/rpm-software-management/rpm/pull/2357.diff'>https://github.com/rpm-software-management/rpm/pull/2357.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br \
/>Reply to this email directly, <a \
href="https://github.com/rpm-software-management/rpm/pull/2357">view it on \
GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU7PNQLRGCIHVZYYVADWSZYFVANCNFSM6AAAAAAT5V33HY">unsubscribe</a>.<br \
/>You are receiving this because you are subscribed to this thread.<img \
src="https://github.com/notifications/beacon/ADLPZU7FBZG3DRVQMAYQIBTWSZYFVA5CNFSM6AAAAAAT5V33H2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFXD5PBY.gif" \
height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: \
none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; \
max-width: 0; max-height: 0; mso-hide: all">Message ID: \
<span><rpm-software-management/rpm/pull/2357</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/2357",
"url": "https://github.com/rpm-software-management/rpm/pull/2357",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic